Conversation
Signed-off-by: Muhammad Awad <MuhammadAbdelghaffar.Awad@amd.com>
Signed-off-by: Muhammad Awad <MuhammadAbdelghaffar.Awad@amd.com>
Signed-off-by: Muhammad Awad <MuhammadAbdelghaffar.Awad@amd.com>
Signed-off-by: Muhammad Awad <MuhammadAbdelghaffar.Awad@amd.com>
Signed-off-by: Muhammad Awad <MuhammadAbdelghaffar.Awad@amd.com>
Signed-off-by: Muhammad Awad <MuhammadAbdelghaffar.Awad@amd.com>
Signed-off-by: Muhammad Awad <MuhammadAbdelghaffar.Awad@amd.com>
Signed-off-by: Muhammad Awad <MuhammadAbdelghaffar.Awad@amd.com>
Signed-off-by: Muhammad Awad <MuhammadAbdelghaffar.Awad@amd.com>
Signed-off-by: Muhammad Awad <MuhammadAbdelghaffar.Awad@amd.com>
Signed-off-by: Muhammad Awad <MuhammadAbdelghaffar.Awad@amd.com>
Signed-off-by: Muhammad Awad <MuhammadAbdelghaffar.Awad@amd.com>
Signed-off-by: Muhammad Awad <MuhammadAbdelghaffar.Awad@amd.com>
Signed-off-by: Muhammad Awad <MuhammadAbdelghaffar.Awad@amd.com>
Signed-off-by: Muhammad Awad <MuhammadAbdelghaffar.Awad@amd.com>
Signed-off-by: Muhammad Awad <MuhammadAbdelghaffar.Awad@amd.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds CI for testing using Apptainer images to address Docker storage issues. The PR includes a new GitHub Actions workflow for automated testing with multiple MPI ranks and updates test files to improve synchronization reliability.
- Add GitHub Actions workflow using Apptainer instead of Docker for CI testing
- Update project dependencies to use specific Triton version from Git repository
- Add synchronization barriers to all test files to prevent race conditions
Reviewed Changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/iris-tests-apptainer.yml |
New CI workflow using Apptainer for testing with multiple MPI ranks |
pyproject.toml |
Updates Triton dependency to specific Git commit |
docker/Dockerfile |
Comments out mpi4py and Triton installation steps |
tests/unittests/test_*.py |
Adds shmem.barrier() calls before kernel execution in all test files |
tests/examples/test_load_bench.py |
Adds barrier synchronization before benchmark loop |
Comments suppressed due to low confidence (1)
.github/workflows/iris-tests-apptainer.yml:1
- Running MPI as root poses security risks and is generally discouraged. Consider creating a non-root user in the container or using proper privilege escalation mechanisms instead of
--allow-run-as-root.
name: Iris Tests with Apptainer
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
neoblizz
approved these changes
Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add CI for testing using Apptainer images. The tests are running one at a time because
pytestis not so friendly with MPI and ends up stuck.Why apptainer and not docker:
Ideally, we want both workflows but long story short, docker is problematic on the host node because we end up using the VFS storage instead of overlay2 and with VFS we end up with 1.6 terabytes of artifacts that we can’t get rid of.
Test Result
Check CI
Submission Checklist