Skip to content

Comments

Add CI for tests#111

Merged
neoblizz merged 47 commits intomainfrom
muhaawad/single-node-ci
Aug 20, 2025
Merged

Add CI for tests#111
neoblizz merged 47 commits intomainfrom
muhaawad/single-node-ci

Conversation

@mawad-amd
Copy link
Collaborator

@mawad-amd mawad-amd commented Aug 19, 2025

Add CI for testing using Apptainer images. The tests are running one at a time because pytest is not so friendly with MPI and ends up stuck.

Why apptainer and not docker:

Ideally, we want both workflows but long story short, docker is problematic on the host node because we end up using the VFS storage instead of overlay2 and with VFS we end up with 1.6 terabytes of artifacts that we can’t get rid of.

Test Result

Check CI

Submission Checklist

Signed-off-by: Muhammad Awad <MuhammadAbdelghaffar.Awad@amd.com>
Signed-off-by: Muhammad Awad <MuhammadAbdelghaffar.Awad@amd.com>
Signed-off-by: Muhammad Awad <MuhammadAbdelghaffar.Awad@amd.com>
Signed-off-by: Muhammad Awad <MuhammadAbdelghaffar.Awad@amd.com>
Signed-off-by: Muhammad Awad <MuhammadAbdelghaffar.Awad@amd.com>
Signed-off-by: Muhammad Awad <MuhammadAbdelghaffar.Awad@amd.com>
Signed-off-by: Muhammad Awad <MuhammadAbdelghaffar.Awad@amd.com>
Signed-off-by: Muhammad Awad <MuhammadAbdelghaffar.Awad@amd.com>
Signed-off-by: Muhammad Awad <MuhammadAbdelghaffar.Awad@amd.com>
Signed-off-by: Muhammad Awad <MuhammadAbdelghaffar.Awad@amd.com>
Signed-off-by: Muhammad Awad <MuhammadAbdelghaffar.Awad@amd.com>
Signed-off-by: Muhammad Awad <MuhammadAbdelghaffar.Awad@amd.com>
Signed-off-by: Muhammad Awad <MuhammadAbdelghaffar.Awad@amd.com>
Signed-off-by: Muhammad Awad <MuhammadAbdelghaffar.Awad@amd.com>
Signed-off-by: Muhammad Awad <MuhammadAbdelghaffar.Awad@amd.com>
@mawad-amd mawad-amd changed the title Add single node CI workflow Add CI for tests Aug 19, 2025
@github-actions github-actions bot added in-progress We are working on it iris Iris project issue labels Aug 19, 2025
Signed-off-by: Muhammad Awad <MuhammadAbdelghaffar.Awad@amd.com>
Signed-off-by: Muhammad Awad <MuhammadAbdelghaffar.Awad@amd.com>
Signed-off-by: Muhammad Awad <MuhammadAbdelghaffar.Awad@amd.com>
@mawad-amd mawad-amd marked this pull request as ready for review August 20, 2025 14:31
Copilot AI review requested due to automatic review settings August 20, 2025 14:31
@mawad-amd mawad-amd requested review from BKP and neoblizz as code owners August 20, 2025 14:31
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds CI for testing using Apptainer images to address Docker storage issues. The PR includes a new GitHub Actions workflow for automated testing with multiple MPI ranks and updates test files to improve synchronization reliability.

  • Add GitHub Actions workflow using Apptainer instead of Docker for CI testing
  • Update project dependencies to use specific Triton version from Git repository
  • Add synchronization barriers to all test files to prevent race conditions

Reviewed Changes

Copilot reviewed 16 out of 17 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
.github/workflows/iris-tests-apptainer.yml New CI workflow using Apptainer for testing with multiple MPI ranks
pyproject.toml Updates Triton dependency to specific Git commit
docker/Dockerfile Comments out mpi4py and Triton installation steps
tests/unittests/test_*.py Adds shmem.barrier() calls before kernel execution in all test files
tests/examples/test_load_bench.py Adds barrier synchronization before benchmark loop
Comments suppressed due to low confidence (1)

.github/workflows/iris-tests-apptainer.yml:1

  • Running MPI as root poses security risks and is generally discouraged. Consider creating a non-root user in the container or using proper privilege escalation mechanisms instead of --allow-run-as-root.
name: Iris Tests with Apptainer

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@neoblizz neoblizz merged commit 8498659 into main Aug 20, 2025
7 checks passed
@neoblizz neoblizz deleted the muhaawad/single-node-ci branch August 20, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in-progress We are working on it iris Iris project issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants