Merged
Conversation
github-actions
bot
added
in-progress
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements a full function for the Iris framework that matches PyTorch's torch.full API. The implementation creates tensors filled with a specified value and ensures they are allocated on the Iris symmetric heap.
Key changes:
- Enhanced the
fullmethod iniris.pyto match PyTorch's API with support for dtype inference, device handling, and output tensor parameters - Added comprehensive test suite covering various scenarios including edge cases, parameter combinations, and PyTorch equivalence
- Implemented proper error handling for invalid parameters and device mismatches
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| iris/iris.py | Updated full method to match PyTorch API with dtype inference, device validation, and comprehensive parameter support |
| tests/unittests/test_full.py | Added comprehensive test suite covering basic functionality, edge cases, parameter combinations, and PyTorch equivalence |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Match
fullfrom PyTorchTechnical Details
Test Plan
Test Result
Submission Checklist