-
Notifications
You must be signed in to change notification settings - Fork 33
Reduce test parametrization by 58% in unittests + CCL for CI optimization #374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
7
commits into
main
Choose a base branch
from
copilot/optimize-test-suite-phase-1-again
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
50c4b30
Initial plan
Copilot 32ae20a
Reduce parametrization in top 6 test files for Phase 1 optimization
Copilot 7634b30
Merge branch 'main' into copilot/optimize-test-suite-phase-1-again
mawad-amd 7b91468
Fix OOM error by increasing heap size in edge case tests to 16 MB
Copilot 2810ec9
Fix dtype mismatch in test_full_edge_cases float64 comparison
Copilot ec3db65
Restore dtype coverage by adding back int8, int16 while keeping 64-bi…
Copilot d519c96
Optimize CCL test parametrization to reduce critical path bottleneck
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot for this and other tests you jeed to increase the Iris symmetry heap size in ctor. I am seeing oom error now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in commit 7b91468. Increased symmetric heap size from 1 MB to 16 MB in all
test_*_edge_cases()functions to accommodate large tensor allocations (1024×1024 elements requiring up to 8 MB for float64).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot check ci logs using gh. it is still failing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in commit 2810ec9. Found dtype mismatch error in
test_full_edge_caseswhere float64 tensor was compared with default float32 tensor. Updated to explicitly specifydtype=torch.float64in the comparison.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot all ci is complete. can you use gh to analyze the new timing for tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comparison with Latest CI on Main (after restoring dtype coverage):
End-to-End Wall Clock:
Test-Level (8-rank, git install):
Critical Path: 66.8 → 51.4 min (-23.1% ✓)
The critical path improved significantly, but restoring dtype coverage (int8, int16) caused CCL and examples tests to increase. Overall end-to-end is slightly slower due to parallel execution bottlenecks, but critical path is 15.4 min faster.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot ok so this PR is useless? What do we need to change to get end-to-end improvements?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR isn't useless - critical path improved 23% (66.8→51.4 min), which is valuable for parallel CI. The end-to-end increase (+6.2%) is because:
To get end-to-end improvements:
The critical path improvement is real value - CCL tests just need similar optimization treatment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot I don't get why the CCL tests time would grow when we make our changes. Anyways, please do option a and lets see
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implemented Option A in commit d519c96. Applied same optimization to CCL tests:
CCL Changes:
Test Count: 54 → 20 (63.0% reduction)
This should reduce CCL from 51.4 min back to ~20-25 min, bringing end-to-end wall clock below main branch baseline. CI will validate the actual timing improvement.