Skip to content

Skip broken amdsmi lifecycle test#519

Merged
mawad-amd merged 1 commit into
mainfrom
muhaawad/skip-broken-topology-test
Apr 25, 2026
Merged

Skip broken amdsmi lifecycle test#519
mawad-amd merged 1 commit into
mainfrom
muhaawad/skip-broken-topology-test

Conversation

@mawad-amd
Copy link
Copy Markdown
Collaborator

@mawad-amd mawad-amd commented Apr 25, 2026

Summary

Test plan

  • CI should go green on main after merge

@mawad-amd @claude
Skip broken amdsmi lifecycle test
0829b49 
The test_amdsmi_query_helpers_do_not_manage_lifecycle test has been
failing on main since the topology refactor in #501/#514. Skip it
until the fix lands.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@mawad-amd mawad-amd requested review from BKP and neoblizz as code owners April 25, 2026 00:58
Copilot AI review requested due to automatic review settings April 25, 2026 00:58
@github-actions github-actions Bot added in-progress We are working on it iris Iris project issue labels Apr 25, 2026
Copilot AI reviewed Apr 25, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Skips a currently failing AMD SMI lifecycle unit test to restore CI stability after the topology refactor.

Changes:

  • Mark test_amdsmi_query_helpers_do_not_manage_lifecycle as skipped with a reason referencing #501/#514.

Comment thread tests/unittests/test_topology.py
Comment thread tests/unittests/test_topology.py
@mawad-amd mawad-amd merged commit dca3faa into main Apr 25, 2026
77 of 81 checks passed
@mawad-amd mawad-amd deleted the muhaawad/skip-broken-topology-test branch April 25, 2026 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@neoblizz neoblizz Awaiting requested review from neoblizz neoblizz is a code owner

@BKP BKP Awaiting requested review from BKP BKP is a code owner

Assignees

No one assigned

Labels

in-progress We are working on it iris Iris project issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mawad-amd