Port skip for "test_prim_tridiagonal_solve" tests from JAX v0.8.0 to v0.8.2#658
Merged
tsrw2048 merged 1 commit intorocm-jaxlib-v0.8.2from Jan 26, 2026
Merged
Conversation
(cherry picked from commit 011e44d)
magaonka-amd
approved these changes
Jan 26, 2026
magaonka-amd
left a comment
There was a problem hiding this comment.
LGTM, again make sure to add upstream PR link once you have it.
Ruturaj4
pushed a commit
that referenced
this pull request
Jan 29, 2026
Ruturaj4
pushed a commit
that referenced
this pull request
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR ports the skips for the
test_prim_tridiagonal_solve_shape*tests as they were failing due to the underlying FFI call (gtsv2) not being marked as stable. The hipSPARSE gtsv2 call currently has numerical errors which need to be resolved before we can mark this FFI call as stable. Until then, we skip the tests.Test Plan
The tests being skipped are:
tests/export_harnesses_multi_platform_test.py::PrimitiveTest::test_prim_tridiagonal_solve_shape_float32_3_tests/export_harnesses_multi_platform_test.py::PrimitiveTest::test_prim_tridiagonal_solve_shape_float64_3_Test Result