Skip to content

Port skip for "test_prim_tridiagonal_solve" tests from JAX v0.8.0 to v0.8.2#658

Merged
tsrw2048 merged 1 commit intorocm-jaxlib-v0.8.2from
skip-prim-tri-solve-test-v0.8.2
Jan 26, 2026
Merged

Port skip for "test_prim_tridiagonal_solve" tests from JAX v0.8.0 to v0.8.2#658
tsrw2048 merged 1 commit intorocm-jaxlib-v0.8.2from
skip-prim-tri-solve-test-v0.8.2

Conversation

@tsrw2048
Copy link

@tsrw2048 tsrw2048 commented Jan 26, 2026

Motivation

This PR ports the skips for the test_prim_tridiagonal_solve_shape* tests as they were failing due to the underlying FFI call (gtsv2) not being marked as stable. The hipSPARSE gtsv2 call currently has numerical errors which need to be resolved before we can mark this FFI call as stable. Until then, we skip the tests.

Test Plan

The tests being skipped are:

  • tests/export_harnesses_multi_platform_test.py::PrimitiveTest::test_prim_tridiagonal_solve_shape_float32_3_
  • tests/export_harnesses_multi_platform_test.py::PrimitiveTest::test_prim_tridiagonal_solve_shape_float64_3_

Test Result

==================================================================== test session starts ====================================================================
platform linux -- Python 3.12.3, pytest-9.0.1, pluggy-1.6.0 -- /usr/bin/python3
cachedir: .pytest_cache
hypothesis profile 'default'
metadata: {'Python': '3.12.3', 'Platform': 'Linux-6.8.0-45-generic-x86_64-with-glibc2.39', 'Packages': {'pytest': '9.0.1', 'pluggy': '1.6.0'}, 'Plugins': {'rerunfailures': '16.1', 'hypothesis': '6.148.2', 'metadata': '3.1.1', 'html': '4.1.1', 'reportlog': '1.0.0', 'json-report': '1.5.0'}}
rootdir: /workspace/rocm-jax/jax
configfile: pyproject.toml
plugins: rerunfailures-16.1, hypothesis-6.148.2, metadata-3.1.1, html-4.1.1, reportlog-1.0.0, json-report-1.5.0
collected 5447 items / 5445 deselected / 2 selected
[TestLogger] Using invocation directory as test name: tests

export_harnesses_multi_platform_test.py::PrimitiveTest::test_prim_tridiagonal_solve_shape_float32_3_ SKIPPED (Tridiagonal Solve (gtsv2) is curren...) [ 50%][TestLogger] Using invocation directory as test name: tests

export_harnesses_multi_platform_test.py::PrimitiveTest::test_prim_tridiagonal_solve_shape_float64_3_ SKIPPED (Tridiagonal Solve (gtsv2) is curren...) [100%][TestLogger] Using invocation directory as test name: tests


============================================================ 2 skipped, 5445 deselected in 4.55s ============================================================

@tsrw2048 tsrw2048 requested a review from a team January 26, 2026 21:36
@tsrw2048 tsrw2048 added open-upstream Tag when you want a copy of this PR to be opened on upstream cherry-pick-candidate Mark a PR to be cherry-picked into the next ROCm JAX. Remove IIF the latest upstream contain the PR. labels Jan 26, 2026
Copy link

@magaonka-amd magaonka-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, again make sure to add upstream PR link once you have it.

@tsrw2048 tsrw2048 merged commit 9ef651c into rocm-jaxlib-v0.8.2 Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick-candidate Mark a PR to be cherry-picked into the next ROCm JAX. Remove IIF the latest upstream contain the PR. open-upstream Tag when you want a copy of this PR to be opened on upstream

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants