Skip test_batch_axis_sharding_jvp13 test 0.8.0#708
Merged
AratiGanesh merged 1 commit intorocm-jaxlib-v0.8.0from Feb 16, 2026
Merged
Skip test_batch_axis_sharding_jvp13 test 0.8.0#708AratiGanesh merged 1 commit intorocm-jaxlib-v0.8.0from
AratiGanesh merged 1 commit intorocm-jaxlib-v0.8.0from
Conversation
AratiGanesh
added
open-upstream
gulsumgudukbay
approved these changes
Feb 10, 2026
gulsumgudukbay
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The test_batch_axis_sharding_jvp13 test (qr with complex64) fails on ROCm devices due to numerical precision issues in rocSolver as of ROCm 7.2.
Technical Details
Added a conditional skip in tests/linalg_sharding_test.py for test_batch_axis_sharding_jvp that only skips when:
Running on ROCm devices (jtu.is_device_rocm())
Function is lax.linalg.qr (fun_and_shapes[0] is lax.linalg.qr)
Dtype is np.complex64 (dtype == np.complex64)
This targets only the failing test case (test_batch_axis_sharding_jvp13). All other test cases continue to run normally.
Test Result
The test is now skipped on ROCm for the specific failing case, preventing test failures while preserving coverage for other variants.
Upstream PR - jax-ml#34966