merge main into amd-staging #538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…7151) All others seem to use std::move in StringSwitch.
Identified with modernize-use-starts-ends-with.
initializeNVPTXCtorDtorLoweringLegacyPass is declared twice in NVPTX.h. initializeGenericToNVVMLegacyPassPass is declared in NVPTX.h. Identified with readability-redundant-declaration.
We can drop .str().c_str() here because all of the following are of type StringRef: - E.Name - the second parameter of llvm::yaml::IO::enumCase - the second parameter of llvm::yaml::IO::bitSetCase Identified with readability-redundant-string-cstr.
…67155) This patch does two things for readability: - Use structured bindings. - Remove extraneous .c_str(). Note that YamlIO.mapRequired takes StringRef as the key type. As such, we can implicitly construct StringRef from std::string.
Note that addMultilibFlag takes StringRef for its second parameter. Identified with readability-redundant-string-cstr.
This ensures that run-buildbot can find the appropriate build tools without having to go through a bunch of hoops inside run-buildbot itself. When we eventually run the bootstrapping build on macOS, it also allows the bootstrapped Clang to find the SDK headers it requires. This also allows simplifying run-buildbot a bunch since we should be able to find build tools in the current $PATH.
Collaborator
Author
ronlieb
approved these changes
Nov 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.