Skip to content

Conversation

@ro-i
Copy link

@ro-i ro-i commented Dec 9, 2025

Adopt Kevin's upstream PR llvm#171082 for amd-staging.

Note: The following tests did not fail due to kmpc_parallel_51/60 renaming and seem to have no offloading anymore:

clang/test/OpenMP/amdgcn_target_device_vla.cpp
clang/test/OpenMP/amdgpu_target_with_aligned_attribute.c
clang/test/OpenMP/target_teams_generic_loop_codegen_as_parallel_for.cpp

See commit "make failed tests work, but not good".

(Do not merge without waiting for PSDB results.)

kevinsala and others added 3 commits December 9, 2025 06:57
…lvm#171082)

This commit switches the `__kmpc_parallel_51` to `__kmpc_parallel_60`,
and adds the strict boolean for the number of threads.
@ro-i ro-i requested a review from ronlieb December 9, 2025 13:57
@github-actions
Copy link

github-actions bot commented Dec 9, 2025

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@z1-cciauto
Copy link
Collaborator

@ro-i
Copy link
Author

ro-i commented Dec 9, 2025

Note: The following tests did not fail due to kmpc_parallel_51/60 renaming and seem to have no offloading anymore:

clang/test/OpenMP/amdgcn_target_device_vla.cpp
clang/test/OpenMP/amdgpu_target_with_aligned_attribute.c
clang/test/OpenMP/target_teams_generic_loop_codegen_as_parallel_for.cpp

See commit "make failed tests work, but not good".

wait, my bad, the stuff that's being removed there had been added by cherry-picking Kevin's commit from upstream. So it just sets the state of the tests back. Should thus be fine

@ro-i
Copy link
Author

ro-i commented Dec 9, 2025

(but some MLIR tests still need adaption)

@z1-cciauto
Copy link
Collaborator

@z1-cciauto
Copy link
Collaborator

@ronlieb ronlieb merged commit 6335f74 into amd-staging Dec 10, 2025
9 checks passed
@ronlieb ronlieb deleted the amd/dev/ro-i/parallel_60 branch December 10, 2025 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants