Fix profiling using amdsmi_cli python module#50
Merged
Conversation
- Updated check_amd_smi_available() to check for Python bindings at /opt/rocm/libexec/amdsmi_cli/ - Falls back to checking command-line tool if bindings not found - This ensures amd_smi_utils.py is used when Python bindings are available, even if CLI tool path differs
coketaste
changed the title
gargrahul
changed the title
gargrahul
approved these changes
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix the installation command in trace.sh by removing the --user flag
Test Plan
Test Result
Submission Checklist