Conversation
…into multiple_columns
Rohan138
commented
Oct 16, 2025
| row["metric"] = r["metric"] | ||
| model = r.pop("model") | ||
| row["model"] = model_name + "_" + str(model) | ||
| row.update(r) |
Contributor
Author
There was a problem hiding this comment.
This allows us to add additional columns to the perf csv; this is really the major change from this PR, the other changes just support this e.g. reordering the columns in the final_multiple_results_df to put any additional columns at the end.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested with unit tests + ongoing vLLM refactor PR.
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist