Fail Check condition update for RPM distro#64
Conversation
coketaste
left a comment
There was a problem hiding this comment.
Could you please update the branch to fix the “This branch is out-of-date with the base branch” warning? After that, it would be great if you could test your madengine changes on CentOS or any other OS.
Hello @coketaste , i have tested my change on SLES 16 OS and its working fine..!! |
There was a problem hiding this comment.
LGTM
@coketaste @gargrahul can you please review and merge if all good.
This is Blocker if we want to run the tags on RPM distro with TheRock build.
It would be great help, if we can review and merge asap.
Thanks.
shashank-parsi
left a comment
There was a problem hiding this comment.
Fixed typo in print(self.console.sh("zypper info rocm-libs", canFail=True))
|
Fix for SWDEV-573276
TheRock doesn't provide any rocm-libs package so it's expected to fail for ROCK based testing.
Like we have for Ubuntu already canFAIL=true, same is applicable for all distros.