Skip to content

Fail Check condition update for RPM distro#64

Merged
gargrahul merged 2 commits intomainfrom
shashank-parsi-patch-1
Feb 5, 2026
Merged

Fail Check condition update for RPM distro#64
gargrahul merged 2 commits intomainfrom
shashank-parsi-patch-1

Conversation

@shashank-parsi
Copy link
Copy Markdown
Contributor

@shashank-parsi shashank-parsi commented Jan 12, 2026

Fix for SWDEV-573276
TheRock doesn't provide any rocm-libs package so it's expected to fail for ROCK based testing.

Like we have for Ubuntu already canFAIL=true, same is applicable for all distros.

Copy link
Copy Markdown
Collaborator

@coketaste coketaste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update the branch to fix the “This branch is out-of-date with the base branch” warning? After that, it would be great if you could test your madengine changes on CentOS or any other OS.

@shashank-parsi
Copy link
Copy Markdown
Contributor Author

Could you please update the branch to fix the “This branch is out-of-date with the base branch” warning? After that, it would be great if you could test your madengine changes on CentOS or any other OS.

Hello @coketaste , i have tested my change on SLES 16 OS and its working fine..!!

Copy link
Copy Markdown

@pramenku pramenku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coketaste @gargrahul can you please review and merge if all good.
This is Blocker if we want to run the tags on RPM distro with TheRock build.

It would be great help, if we can review and merge asap.

Thanks.

@pramenku pramenku changed the title Fix for SWDEV-573276 Fail Check condition update for RPM distro Feb 5, 2026
@gargrahul gargrahul merged commit 9bf6ae6 into main Feb 5, 2026
Copy link
Copy Markdown
Collaborator

@coketaste coketaste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor Author

@shashank-parsi shashank-parsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed typo in print(self.console.sh("zypper info rocm-libs", canFail=True))

@puichay
Copy link
Copy Markdown

puichay commented Mar 23, 2026

Fix for SWDEV-573276
TheRock doesn't provide any rocm-libs package so it's expected to fail for ROCK based testing.

Like we have for Ubuntu already canFAIL=true, same is applicable for all distros.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants