Merged
Conversation
Contributor
Author
|
@gargrahul CI passed, please merge |
gargrahul
approved these changes
Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out
docker buildwith buildkit does not actually tag the pulled base image anymore (https://forums.docker.com/t/why-arent-base-layer-images-listed-in-docker-image-ls-a/139044/2), so the fix in #5 doesn't work. i.e. docker complains that the image e.g.rocm/pytorch:latestis not present.Reverted to using
docker manifest inspectwhich works with remote images+added some grep+cut commands to get around the jq dependency for parsing.Also added a ^ in front of the grep for the BASE_DOCKER to fix issues like https://github.com/ROCm/DeepLearningModels/pull/2567.