Fix RDMA chunking for oversized multi-SGE WRs#409
Merged
Conversation
e638877 to
718a34f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ibv_post_send.max_msg_szcapability onRdmaEndpointwithout serializing it to peers.Background
A large batch can be merged into a multi-SGE WR whose total message length exceeds the local provider
max_msg_sz. The old chunker only split oversized single-SGE WRs, so these multi-SGE WRs could bypass chunking and be rejected by the verbs provider. This keeps the merge fast path for small WRs while enforcing the local message-size limit when transfer chunking is enabled.Validation
BUILD_TESTS=1 pip install ../build/tests/cpp/test_engine