Skip to content

Sow ms7 enable test reference numerics small all except complex #1134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Sow ms7 enable test reference numerics small all except complex #1134

wants to merge 3 commits into from

Conversation

bmedishe
Copy link

@bmedishe bmedishe commented Nov 2, 2022

This PR is to enable tests which are skip on rocm from test package test_unary_ufuncs.py::TestUnaryUfuncsCUDA

test_file test_name test_class
test_unary_ufuncs test_reference_numerics_large_polygamma_polygamma_n_2_cuda_float16 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_large_polygamma_polygamma_n_2_cuda_float32 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_large_polygamma_polygamma_n_2_cuda_float64 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_large_polygamma_polygamma_n_2_cuda_int16 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_large_polygamma_polygamma_n_2_cuda_int32 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_large_polygamma_polygamma_n_2_cuda_int64 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_large_polygamma_polygamma_n_4_cuda_float16 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_large_polygamma_polygamma_n_4_cuda_float32 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_large_polygamma_polygamma_n_4_cuda_float64 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_large_polygamma_polygamma_n_4_cuda_int16 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_large_polygamma_polygamma_n_4_cuda_int32 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_large_polygamma_polygamma_n_4_cuda_int64 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_large_tan_cuda_float64 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_small_atan_cuda_bfloat16 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_small_atan_cuda_float16 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_small_atan_cuda_float32 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_small_atan_cuda_float64 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_small_atan_cuda_int16 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_small_atan_cuda_int32 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_small_atan_cuda_int64 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_small_atan_cuda_int8 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_small_atan_cuda_uint8 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_small_polygamma_polygamma_n_2_cuda_float16 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_small_polygamma_polygamma_n_2_cuda_float32 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_small_polygamma_polygamma_n_2_cuda_float64 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_small_polygamma_polygamma_n_2_cuda_int16 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_small_polygamma_polygamma_n_2_cuda_int32 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_small_polygamma_polygamma_n_2_cuda_int64 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_small_polygamma_polygamma_n_2_cuda_int8 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_small_polygamma_polygamma_n_2_cuda_uint8 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_small_polygamma_polygamma_n_4_cuda_float16 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_small_polygamma_polygamma_n_4_cuda_float32 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_small_polygamma_polygamma_n_4_cuda_float64 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_small_polygamma_polygamma_n_4_cuda_int16 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_small_polygamma_polygamma_n_4_cuda_int32 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_small_polygamma_polygamma_n_4_cuda_int64 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_small_polygamma_polygamma_n_4_cuda_int8 (main.TestUnaryUfuncsCUDA)
test_unary_ufuncs test_reference_numerics_small_polygamma_polygamma_n_4_cuda_uint8 (main.TestUnaryUfuncsCUDA)

@bmedishe
Copy link
Author

bmedishe commented Nov 2, 2022 •
edited
Loading

These tests were skipped from PR Various OpInfo architecture improvements
few tests belonging to this package were enabled for rocm in ROCM: Enable few more tests for ROCM

Before PR
PYTORCH_TEST_WITH_ROCM=1 pytest -s test_unary_ufuncs.py::TestUnaryUfuncsCUDA
12428 passed, 514 skipped, 17 xfailed, 15 warnings
After PR
PYTORCH_TEST_WITH_ROCM=1 pytest -s test_unary_ufuncs.py::TestUnaryUfuncsCUDA
12467 passed, 475 skipped, 17 xfailed, 15 warnings

@bmedishe bmedishe self-assigned this Nov 2, 2022
@pruthvistony
Copy link
Collaborator

jenkins retest this please

@pruthvistony
Copy link
Collaborator

@bmedishe ,
Please check the CI logs to ensure if the new UTs are getting executed and if it is executed, can you please post the logs in comments.

@bmedishe
Copy link
Author

jenkins retest this please

@bmedishe
Copy link
Author

All the above tests pass in upstream CI https://github.com/pytorch/pytorch/actions/runs/3465630790/jobs/5788831616

@pruthvistony
Copy link
Collaborator

@bmedishe ,
Can you raise this change to upstream pytorch/pytorch and another PR into rocm5.5_internal_testing branch

@bmedishe
Copy link
Author

@bmedishe , Can you raise this change to upstream pytorch/pytorch and another PR into rocm5.5_internal_testing branch

@pruthvistony upstream PR which is merged pytorch#89007
will file a PR on rocm5.5_internal_testing branch

akashveramd pushed a commit that referenced this pull request Jun 13, 2025
@lkhphuc
dist_utils: set extra process group default to None (#1134)
30b9ea0 
Recently introduced 'extra_pg' in distributed utils does not provide a
default.
Set default to None like the underlying `dist_reduce`.

This is to avoid breaking forks that currently uses `dist_mean` or
`dist_max`.
xinyazhang pushed a commit that referenced this pull request Aug 30, 2025
@malfet @pytorchmergebot
Cleanup stale submodule directories in checkout action (pytorch#161748)
f3c5a82 
Fixes pytorch#161510

Test plan:
```
% cd third_party/kineto
% git checkout fe80f9319479265f7a208e615e16a363b993d50c; git submodule update --init --recursive
M	libkineto/third_party/dynolog
M	libkineto/third_party/fmt
M	libkineto/third_party/googletest
Previous HEAD position was 5e75018 Fix Local Time on Windows Builds (#1104)
HEAD is now at fe80f93 Fix MSVC Error (#1134)
Submodule path 'libkineto/third_party/dynolog': checked out 'd2ffe0a4e3acace628db49974246b66fc3e85fb1'
Submodule path 'libkineto/third_party/dynolog/third_party/googletest': checked out '52eb8108c5bdec04579160ae17225d66034bd723'
Submodule path 'libkineto/third_party/dynolog/third_party/prometheus-cpp': checked out 'b1234816facfdda29845c46696a02998a4af115a'
Submodule path 'libkineto/third_party/dynolog/third_party/prometheus-cpp/3rdparty/civetweb': checked out 'd7ba35bbb649209c66e582d5a0244ba988a15159'
Submodule path 'libkineto/third_party/dynolog/third_party/prometheus-cpp/3rdparty/googletest': checked out 'e2239ee6043f73722e7aa812a459f54a28552929'
Submodule path 'libkineto/third_party/fmt': checked out '40626af88bd7df9a5fb80be7b25ac85b122d6c21'
Submodule path 'libkineto/third_party/googletest': checked out '52eb8108c5bdec04579160ae17225d66034bd723'
% git checkout 5e75018; git submodule update --init --recursive
M	libkineto/third_party/dynolog
M	libkineto/third_party/fmt
M	libkineto/third_party/googletest
Previous HEAD position was fe80f93 Fix MSVC Error (#1134)
HEAD is now at 5e75018 Fix Local Time on Windows Builds (#1104)
warning: unable to rmdir 'third_party/prometheus-cpp': Directory not empty
Submodule path 'libkineto/third_party/dynolog': checked out '7d04a0053a845370ae06ce317a22a48e9edcc74e'
Submodule path 'libkineto/third_party/dynolog/third_party/googletest': checked out '58d77fa8070e8cec2dc1ed015d66b454c8d78850'
Submodule path 'libkineto/third_party/fmt': checked out '0041a40c1350ba702d475b9c4ad62da77caea164'
Submodule path 'libkineto/third_party/googletest': checked out '7aca84427f224eeed3144123d5230d5871e93347'
% cd ../..
% git status
HEAD detached from 649e397
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
  (commit or discard the untracked or modified content in submodules)
	modified:   third_party/kineto (untracked content)

% time git submodule foreach --recursive git clean -ffdx
...
git submodule foreach --recursive git clean -ffdx  0.47s user 0.96s system 88% cpu 1.625 total
% git status
HEAD detached from 649e397
```
Pull Request resolved: pytorch#161748
Approved by: https://github.com/atalman
xinyazhang pushed a commit that referenced this pull request Aug 30, 2025
@malfet @pytorchmergebot
Cleanup stale submodule directories after checkout (pytorch#161748)
0e45023 
Fixes pytorch#161510

Test plan:
```
% cd third_party/kineto
% git checkout fe80f9319479265f7a208e615e16a363b993d50c; git submodule update --init --recursive
M	libkineto/third_party/dynolog
M	libkineto/third_party/fmt
M	libkineto/third_party/googletest
Previous HEAD position was 5e75018 Fix Local Time on Windows Builds (#1104)
HEAD is now at fe80f93 Fix MSVC Error (#1134)
Submodule path 'libkineto/third_party/dynolog': checked out 'd2ffe0a4e3acace628db49974246b66fc3e85fb1'
Submodule path 'libkineto/third_party/dynolog/third_party/googletest': checked out '52eb8108c5bdec04579160ae17225d66034bd723'
Submodule path 'libkineto/third_party/dynolog/third_party/prometheus-cpp': checked out 'b1234816facfdda29845c46696a02998a4af115a'
Submodule path 'libkineto/third_party/dynolog/third_party/prometheus-cpp/3rdparty/civetweb': checked out 'd7ba35bbb649209c66e582d5a0244ba988a15159'
Submodule path 'libkineto/third_party/dynolog/third_party/prometheus-cpp/3rdparty/googletest': checked out 'e2239ee6043f73722e7aa812a459f54a28552929'
Submodule path 'libkineto/third_party/fmt': checked out '40626af88bd7df9a5fb80be7b25ac85b122d6c21'
Submodule path 'libkineto/third_party/googletest': checked out '52eb8108c5bdec04579160ae17225d66034bd723'
% git checkout 5e75018; git submodule update --init --recursive
M	libkineto/third_party/dynolog
M	libkineto/third_party/fmt
M	libkineto/third_party/googletest
Previous HEAD position was fe80f93 Fix MSVC Error (#1134)
HEAD is now at 5e75018 Fix Local Time on Windows Builds (#1104)
warning: unable to rmdir 'third_party/prometheus-cpp': Directory not empty
Submodule path 'libkineto/third_party/dynolog': checked out '7d04a0053a845370ae06ce317a22a48e9edcc74e'
Submodule path 'libkineto/third_party/dynolog/third_party/googletest': checked out '58d77fa8070e8cec2dc1ed015d66b454c8d78850'
Submodule path 'libkineto/third_party/fmt': checked out '0041a40c1350ba702d475b9c4ad62da77caea164'
Submodule path 'libkineto/third_party/googletest': checked out '7aca84427f224eeed3144123d5230d5871e93347'
% cd ../..
% git status
HEAD detached from 649e397
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
  (commit or discard the untracked or modified content in submodules)
	modified:   third_party/kineto (untracked content)

% time git submodule foreach --recursive git clean -ffdx
...
git submodule foreach --recursive git clean -ffdx  0.47s user 0.96s system 88% cpu 1.625 total
% git status
HEAD detached from 649e397
```
Pull Request resolved: pytorch#161748
Approved by: https://github.com/atalman
xinyazhang pushed a commit that referenced this pull request Aug 30, 2025
@malfet @pytorchmergebot
Cleanup stale submodule directories after checkout (pytorch#161748)
0af56fc 
Fixes pytorch#161510

Test plan:
```
% cd third_party/kineto
% git checkout fe80f9319479265f7a208e615e16a363b993d50c; git submodule update --init --recursive
M	libkineto/third_party/dynolog
M	libkineto/third_party/fmt
M	libkineto/third_party/googletest
Previous HEAD position was 5e75018 Fix Local Time on Windows Builds (#1104)
HEAD is now at fe80f93 Fix MSVC Error (#1134)
Submodule path 'libkineto/third_party/dynolog': checked out 'd2ffe0a4e3acace628db49974246b66fc3e85fb1'
Submodule path 'libkineto/third_party/dynolog/third_party/googletest': checked out '52eb8108c5bdec04579160ae17225d66034bd723'
Submodule path 'libkineto/third_party/dynolog/third_party/prometheus-cpp': checked out 'b1234816facfdda29845c46696a02998a4af115a'
Submodule path 'libkineto/third_party/dynolog/third_party/prometheus-cpp/3rdparty/civetweb': checked out 'd7ba35bbb649209c66e582d5a0244ba988a15159'
Submodule path 'libkineto/third_party/dynolog/third_party/prometheus-cpp/3rdparty/googletest': checked out 'e2239ee6043f73722e7aa812a459f54a28552929'
Submodule path 'libkineto/third_party/fmt': checked out '40626af88bd7df9a5fb80be7b25ac85b122d6c21'
Submodule path 'libkineto/third_party/googletest': checked out '52eb8108c5bdec04579160ae17225d66034bd723'
% git checkout 5e75018; git submodule update --init --recursive
M	libkineto/third_party/dynolog
M	libkineto/third_party/fmt
M	libkineto/third_party/googletest
Previous HEAD position was fe80f93 Fix MSVC Error (#1134)
HEAD is now at 5e75018 Fix Local Time on Windows Builds (#1104)
warning: unable to rmdir 'third_party/prometheus-cpp': Directory not empty
Submodule path 'libkineto/third_party/dynolog': checked out '7d04a0053a845370ae06ce317a22a48e9edcc74e'
Submodule path 'libkineto/third_party/dynolog/third_party/googletest': checked out '58d77fa8070e8cec2dc1ed015d66b454c8d78850'
Submodule path 'libkineto/third_party/fmt': checked out '0041a40c1350ba702d475b9c4ad62da77caea164'
Submodule path 'libkineto/third_party/googletest': checked out '7aca84427f224eeed3144123d5230d5871e93347'
% cd ../..
% git status
HEAD detached from 649e397
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
  (commit or discard the untracked or modified content in submodules)
	modified:   third_party/kineto (untracked content)

% time git submodule foreach --recursive git clean -ffdx
...
git submodule foreach --recursive git clean -ffdx  0.47s user 0.96s system 88% cpu 1.625 total
% git status
HEAD detached from 649e397
```
Pull Request resolved: pytorch#161748
Approved by: https://github.com/atalman
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pruthvistony pruthvistony pruthvistony approved these changes

@jithunnair-amd jithunnair-amd Awaiting requested review from jithunnair-amd

Assignees

@bmedishe bmedishe

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bmedishe @pruthvistony