[release/2.6] skip convolution tests on Navi #2055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnikolaev-amd
force-pushed
the
rel2.6_skip_convolution_tests_on_navi
branch
from
64b148e to
a753b21
Compare
Fixes: SWDEV-527625 - test_jit.py::TestFrozenOptimizations::test_freeze_conv_relu_fusion* - skipped on Navi4, not supported by MIOpen - nn/test_convolution.py::TestConvolutionNNDeviceTypeCUDA::test_cudnn_convolution_relu_cuda_float32 - skipped on Navi4, not supported by MIOpen (partially cherry picked from commit a07b6bf)
dnikolaev-amd
force-pushed
the
rel2.6_skip_convolution_tests_on_navi
branch
from
a753b21 to
2fc5cb1
Compare
|
Jenkins build for 2fc5cb109e490f31bbf084ca1797a12ab0ce617e commit is in progress |
pruthvistony
approved these changes
Apr 28, 2025
Collaborator
|
Please upstream this patch. |
jithunnair-amd
pushed a commit
that referenced
this pull request
Apr 28, 2025
MIOpen doesn't support convolution on Navi - add `NAVI_ARCH` and `skipIfRocmArch` to common_utils.py - test_jit.py::TestFrozenOptimizations::test_freeze_conv_relu_fusion* - skipped on Navi4, not supported by MIOpen - nn/test_convolution.py::TestConvolutionNNDeviceTypeCUDA::test_cudnn_convolution_relu_cuda_float32 - skipped on Navi4, not supported by MIOpen Fixes: SWDEV-527625 (partially cherry picked from commit a07b6bf)
jithunnair-amd
pushed a commit
that referenced
this pull request
Jun 5, 2025
MIOpen doesn't support convolution on Navi - add `NAVI_ARCH` and `skipIfRocmArch` to common_utils.py - test_jit.py::TestFrozenOptimizations::test_freeze_conv_relu_fusion* - skipped on Navi4, not supported by MIOpen - nn/test_convolution.py::TestConvolutionNNDeviceTypeCUDA::test_cudnn_convolution_relu_cuda_float32 - skipped on Navi4, not supported by MIOpen Fixes: SWDEV-527625 (partially cherry picked from commit a07b6bf) (cherry picked from commit e53a999)
jithunnair-amd
pushed a commit
that referenced
this pull request
Jun 6, 2025
MIOpen doesn't support convolution on Navi - add `NAVI_ARCH` and `skipIfRocmArch` to common_utils.py - test_jit.py::TestFrozenOptimizations::test_freeze_conv_relu_fusion* - skipped on Navi4, not supported by MIOpen - nn/test_convolution.py::TestConvolutionNNDeviceTypeCUDA::test_cudnn_convolution_relu_cuda_float32 - skipped on Navi4, not supported by MIOpen Fixes: SWDEV-527625 (partially cherry picked from commit a07b6bf) (cherry picked from commit e53a999)
|
! cherry-pick --onto release/2.8 |
|
Created branch autogenerated/release/2.8_cherry-pick_pr-2055 and #2675. It contains a merge conflict. Please resolve it Comment processed by Build |
k-artem
added a commit
that referenced
this pull request
Sep 26, 2025
Cherry-pick of #2055, but changed due to these testcases work on Navi3x as expected, for Navi4x these testcases skipped until support of next kernels will be added: * for test_freeze_conv_relu_fusion_not_forward and test_freeze_conv_relu_fusion: `ConvBinWinogradRxSf2x3g1Fused` * for test_cudnn_convolution_relu: `ConvBinWinogradRxSf2x3g1`, `ConvBinWinogradRxSf2x3g1Fused` and `ConvWinoFuryRxS<2-3>` #SWDEV-555401 --------- Co-authored-by: Dmitry Nikolaev <139769634+dnikolaev-amd@users.noreply.github.com> Co-authored-by: Artem Kuzmitckii <akuzmitc@amd.com>
k-artem
added a commit
that referenced
this pull request
Nov 3, 2025
Cherry-pick of next(should be reverted as soons as wino conv kernels will be added to miopen, work in progress): [AUTOGENERATED] [release/2.8] skip convolution tests on Navi4x (#2675) Cherry-pick of #2055, but changed due to these testcases work on Navi3x as expected, for Navi4x these testcases skipped until support of next kernels will be added: * for test_freeze_conv_relu_fusion_not_forward and test_freeze_conv_relu_fusion: `ConvBinWinogradRxSf2x3g1Fused` * for test_cudnn_convolution_relu: `ConvBinWinogradRxSf2x3g1`, `ConvBinWinogradRxSf2x3g1Fused` and `ConvWinoFuryRxS<2-3>` --------- Co-authored-by: Dmitry Nikolaev <139769634+dnikolaev-amd@users.noreply.github.com> Co-authored-by: Artem Kuzmitckii <akuzmitc@amd.com> (cherry picked from commit 245bf6e)
k-artem
added a commit
that referenced
this pull request
Nov 3, 2025
Cherry-pick of #2675 (original commit #2055), for Navi4x only these testcases skipped until support of next kernels will be added (progress can be tracked here ROCm/rocm-libraries#2237): for test_freeze_conv_relu_fusion_not_forward and test_freeze_conv_relu_fusion: ConvBinWinogradRxSf2x3g1Fused for test_cudnn_convolution_relu: ConvBinWinogradRxSf2x3g1, ConvBinWinogradRxSf2x3g1Fused and ConvWinoFuryRxS<2-3> Fixes #SWDEV-555401 Co-authored-by: Divin Honnappa <divin.honnappa@amd.com> Co-authored-by: Dmitry Nikolaev <139769634+dnikolaev-amd@users.noreply.github.com>
jeffdaily
pushed a commit
that referenced
this pull request
Nov 17, 2025
Cherry-pick of #2675 (original commit #2055), for Navi4x only these testcases skipped until support of next kernels will be added (progress can be tracked here ROCm/rocm-libraries#2237): for test_freeze_conv_relu_fusion_not_forward and test_freeze_conv_relu_fusion: ConvBinWinogradRxSf2x3g1Fused for test_cudnn_convolution_relu: ConvBinWinogradRxSf2x3g1, ConvBinWinogradRxSf2x3g1Fused and ConvWinoFuryRxS<2-3> Fixes #SWDEV-555401 Co-authored-by: Divin Honnappa <divin.honnappa@amd.com> Co-authored-by: Dmitry Nikolaev <139769634+dnikolaev-amd@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MIOpen doesn't support convolution on Navi
NAVI_ARCHandskipIfRocmArchto common_utils.pyFixes: SWDEV-527625
(partially cherry picked from commit a07b6bf)
Cherry-picked to release/2.8 branch via #2675