[AUTOGENERATED] [release/2.8] skip convolution tests on Navi4x #2675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix merge conflicts
Fix merge conflicts
|
Jenkins build for 3f3b83a1d1f941638ee4f2c8c290b4d583e8d17f commit finished as FAILURE |
For both tests (nn and jit) we need support of `ConvBinWinogradRxSf2x3g1Fused` kernel in MIOpen which currently doesn't support for NAVI4(gfx12x), but it works for NAVI3(gfx11x), so enable tests for NAVI3 but keep disabled for NAVI4.
For both tests (nn and jit) we need support of `ConvBinWinogradRxSf2x3g1Fused` kernel in MIOpen which currently doesn't support for NAVI4(gfx12x), but it works for NAVI3(gfx11x), so enable tests for NAVI3 but keep disabled for NAVI4.
|
Jenkins build for cd1d7515b957788d9eb218ff87a9bee5afa2e116 commit finished as NOT_BUILT |
Enable for Navi3x
k-artem
changed the title
|
Jenkins build for cd1d7515b957788d9eb218ff87a9bee5afa2e116 commit finished as SUCCESS |
|
@pruthvistony please review. |
|
! cherry-pick --onto release/2.9 |
This was referenced Nov 3, 2025
|
Created branch autogenerated/release/2.9_cherry-pick_pr-2675 and #2774. It contains a merge conflict. Please resolve it Comment processed by Build |
k-artem
added a commit
that referenced
this pull request
Nov 3, 2025
Cherry-pick of next(should be reverted as soons as wino conv kernels will be added to miopen, work in progress): [AUTOGENERATED] [release/2.8] skip convolution tests on Navi4x (#2675) Cherry-pick of #2055, but changed due to these testcases work on Navi3x as expected, for Navi4x these testcases skipped until support of next kernels will be added: * for test_freeze_conv_relu_fusion_not_forward and test_freeze_conv_relu_fusion: `ConvBinWinogradRxSf2x3g1Fused` * for test_cudnn_convolution_relu: `ConvBinWinogradRxSf2x3g1`, `ConvBinWinogradRxSf2x3g1Fused` and `ConvWinoFuryRxS<2-3>` --------- Co-authored-by: Dmitry Nikolaev <139769634+dnikolaev-amd@users.noreply.github.com> Co-authored-by: Artem Kuzmitckii <akuzmitc@amd.com> (cherry picked from commit 245bf6e)
k-artem
added a commit
that referenced
this pull request
Nov 3, 2025
Cherry-pick of #2675 (original commit #2055), for Navi4x only these testcases skipped until support of next kernels will be added (progress can be tracked here ROCm/rocm-libraries#2237): for test_freeze_conv_relu_fusion_not_forward and test_freeze_conv_relu_fusion: ConvBinWinogradRxSf2x3g1Fused for test_cudnn_convolution_relu: ConvBinWinogradRxSf2x3g1, ConvBinWinogradRxSf2x3g1Fused and ConvWinoFuryRxS<2-3> Fixes #SWDEV-555401 Co-authored-by: Divin Honnappa <divin.honnappa@amd.com> Co-authored-by: Dmitry Nikolaev <139769634+dnikolaev-amd@users.noreply.github.com>
jeffdaily
pushed a commit
that referenced
this pull request
Nov 17, 2025
Cherry-pick of #2675 (original commit #2055), for Navi4x only these testcases skipped until support of next kernels will be added (progress can be tracked here ROCm/rocm-libraries#2237): for test_freeze_conv_relu_fusion_not_forward and test_freeze_conv_relu_fusion: ConvBinWinogradRxSf2x3g1Fused for test_cudnn_convolution_relu: ConvBinWinogradRxSf2x3g1, ConvBinWinogradRxSf2x3g1Fused and ConvWinoFuryRxS<2-3> Fixes #SWDEV-555401 Co-authored-by: Divin Honnappa <divin.honnappa@amd.com> Co-authored-by: Dmitry Nikolaev <139769634+dnikolaev-amd@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #2055, but changed due to these testcases work on Navi3x as expected, for Navi4x these testcases skipped until support of next kernels will be added:
ConvBinWinogradRxSf2x3g1FusedConvBinWinogradRxSf2x3g1,ConvBinWinogradRxSf2x3g1FusedandConvWinoFuryRxS<2-3>#SWDEV-555401
Cherry-picked to release/2.9 branch via #2775