[release/2.7][SWDEV-544125] update test buffer fudge factor for hipblaslt for test_fully_shard_training_memory test #2493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default workspace for hipblaslt is larger than for cublas/cublaslt which requires a slight increase to the buffer needed. Forward-fix for pytorch#150227 that broke ROCm distributed tests but wasn't part of initial CI signal. Pull Request resolved: pytorch#150348 Approved by: https://github.com/jeffdaily
|
Jenkins build for 353f4ffb313e0f91191f65c8350bea11ced2705e commit finished as FAILURE |
pragupta
approved these changes
Aug 15, 2025
pragupta
changed the title
Author
|
! cherry-pick --onto release/2.8 rocm7.0_internal_testing rocm7.1_internal_testing |
|
Nothing to cherry-pick onto the release/2.8 branch Nothing to cherry-pick onto the rocm7.0_internal_testing branch Nothing to cherry-pick onto the rocm7.1_internal_testing branch Comment processed by Build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I cherry picked upstream commit 78300c8.
This fixes the test_fully_shard_training_memory test under /distributed/_composable/fsdp/test_fully_shard_memory.py.
It was a failing test in Jira https://ontrack-internal.amd.com/browse/SWDEV-544125