Skip to content

[release/2.7][SWDEV-544125] update test buffer fudge factor for hipblaslt for test_fully_shard_training_memory test #2493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2025
Merged

[release/2.7][SWDEV-544125] update test buffer fudge factor for hipblaslt for test_fully_shard_training_memory test #2493

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions test/distributed/_composable/fsdp/test_fully_shard_memory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,9 @@ def _test_fully_shard_training_memory(
# number is kept much smaller than the actual memory usage, which is on
# the order of 100-200+ MB)
buffer_mb = 16
# The default workspace for hipblaslt is larger than for cublas/cublaslt
# which requires a slight increase to this buffer value.
buffer_mb = 16 if torch.version.cuda else 18
if reshard_after_forward:
# 3x max unsharded block parameters (current all-gather + copy-out
# and next all-gather), non-block parameters, and other
Expand Down