Minor improvements cherry-pick #283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iotamudelta
commented
Oct 22, 2018
iotamudelta
commented
- enable Unique
- enable fp16 TopK
- enable previously disabled functions
* rocRAND brings Poisson RNG - don't disable functions * At the very least the WARP_SIZE is wrong for ROCm. * Do not disable renorm kernel * Put the ifdef directly in to ensure better maintainability. * scalar_cast does not exist any longer. * Implement the one ifdef directly, CUDA_VERSION check is not in the file any longer.
…take non-const arg as const kernel arg (ROCm 281)
Author
|
@pytorchbot retest this please |
1 similar comment
Author
|
@pytorchbot retest this please |
iotamudelta
added
the
cherry-picked
facebook-github-bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Oct 23, 2018
Summary: * Enable disabled functions for ROCm (ROCm 252) * fixes for topk fp16 (ROCm 270) * HIP needs kernel invocation to be explicitly templated to be able to take non-const arg as const kernel arg (ROCm 281) For attention: bddppq ezyang Full set of PyTorch/Caffe2 tests on ROCm here: ROCm#283 Pull Request resolved: #12973 Differential Revision: D10516072 Pulled By: bddppq fbshipit-source-id: 833b3de1544dfa4886a34e2b5ea53d77b6f0ba9e
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Oct 23, 2018
Summary: * Enable disabled functions for ROCm (ROCm 252) * fixes for topk fp16 (ROCm 270) * HIP needs kernel invocation to be explicitly templated to be able to take non-const arg as const kernel arg (ROCm 281) For attention: bddppq ezyang Full set of PyTorch/Caffe2 tests on ROCm here: ROCm/pytorch#283 Pull Request resolved: pytorch/pytorch#12973 Differential Revision: D10516072 Pulled By: bddppq fbshipit-source-id: 833b3de1544dfa4886a34e2b5ea53d77b6f0ba9e
amd-sriram
pushed a commit
that referenced
this pull request
Nov 24, 2025
Commit Messages: - Update README.md (#288) - Update version to 1.9.0 (#283) - add code to read BUILD_VERSION env variable, so that it is used instead of version.txt when creating a wheel (#279) PRs: - ROCm/apex#288 Fixes: - https://example.com/issue-288 - https://example.com/issue-283 - https://example.com/issue-279
amd-sriram
pushed a commit
that referenced
this pull request
Nov 24, 2025
Commit Messages: - Update README.md (#288) - Update version to 1.9.0 (#283) - add code to read BUILD_VERSION env variable, so that it is used instead of version.txt when creating a wheel (#279) PRs: - ROCm/apex#288 Fixes: - https://example.com/issue-288 - https://example.com/issue-279 - https://example.com/issue-283
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.