Enable test_nn embedding tests and use correct warp size in Embedding.cu (ROCm 285) #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iotamudelta
commented
Oct 24, 2018
iotamudelta
commented
- Enable test_nn embedding tests and use correct warp size in Embedding.cu
- Fix embedding_backward_feature_kernel kernel for HIP
….cu (ROCm 285) * Enable test_nn embedding tests and use correct warp size in Embedding.cu * Fix embedding_backward_feature_kernel kernel for HIP
iotamudelta
added
the
cherry-picked
Author
|
@pytorchbot retest this please |
Author
|
windows failure is unrelated - merging. |
akashveramd
pushed a commit
that referenced
this pull request
Jun 13, 2025
as titled, fixes pytorch/torchtitan#286
amd-sriram
pushed a commit
that referenced
this pull request
Nov 24, 2025
Commit Messages: - Update README.md (#288) - Update version to 1.9.0 (#283) - add code to read BUILD_VERSION env variable, so that it is used instead of version.txt when creating a wheel (#279) PRs: - ROCm/apex#288 Fixes: - https://example.com/issue-288 - https://example.com/issue-283 - https://example.com/issue-279
amd-sriram
pushed a commit
that referenced
this pull request
Nov 24, 2025
Commit Messages: - Update README.md (#288) - Update version to 1.9.0 (#283) - add code to read BUILD_VERSION env variable, so that it is used instead of version.txt when creating a wheel (#279) PRs: - ROCm/apex#288 Fixes: - https://example.com/issue-288 - https://example.com/issue-279 - https://example.com/issue-283
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.