[release/2.9] Fix numpy compatibility for Python 3.14 for 2.9#3099
Merged
jithunnair-amd merged 3 commits intorelease/2.9from Mar 25, 2026
Merged
[release/2.9] Fix numpy compatibility for Python 3.14 for 2.9#3099jithunnair-amd merged 3 commits intorelease/2.9from
jithunnair-amd merged 3 commits intorelease/2.9from
Conversation
subodh-dubey-amd
changed the title
1 task
|
Jenkins build for b4fe646b584db7f78553cded24a01d9695430d96 commit finished as NOT_BUILT |
Merged
1 task
Collaborator
|
@subodh-dubey-amd Please test with the latest changes, and we can merge if build passes. |
|
Jenkins build for b4fe646b584db7f78553cded24a01d9695430d96 commit finished as FAILURE |
Author
https://github.com/ROCm/TheRock/actions/runs/23516862647/job/68451235656 |
jithunnair-amd
changed the title
subodh-dubey-amd
added a commit
to ROCm/TheRock
that referenced
this pull request
Mar 25, 2026
## Summary - Add Python 3.14 to the PyTorch release workflow matrices for release/2.9, release/2.10, and nightly - Add `cp314` to the S3 dependency index allowlist so third-party wheels (numpy, etc.) are uploaded for Python 3.14 - Update RELEASES.md to document Python 3.14 support ## Dependency chain This PR depends on the following being merged first: 1. **TheRock** #3540 2. **ROCm/pytorch** ROCm/pytorch#3099 3. **ROCm/pytorch** ROCm/pytorch#3100 The ROCm/pytorch PRs fix `numpy==2.1.2` having no cp314 wheels, which causes the build to fail when pip falls back to a source build under sccache/meson. ## Python 3.14 support matrix | PyTorch version | Python 3.14 support | |-----------------|---------------------| | 2.8 | Not supported | | 2.9 | Supported | | 2.10 | Supported | | nightly | Supported | ## Changes - `release_portable_linux_pytorch_wheels.yml` — add py3.14 include entries for release/2.9, release/2.10, nightly - `release_windows_pytorch_wheels.yml` — add py3.14 to the version list - `update_dependencies.py` — add `cp314` to `_ALLOWED_CPYTHON_TAGS` - `RELEASES.md` — update supported Python versions ## Test results - Nightly py3.14 (already passing): https://github.com/ROCm/TheRock/actions/runs/23488558012/job/68350335178 - release/2.9 py3.14 (with numpy fix): https://github.com/ROCm/TheRock/actions/runs/23516862647/job/68451235656 Latest after this merge - ROCm/pytorch#3099: https://github.com/ROCm/TheRock/actions/runs/23546615437/job/68548629107 - release/2.10 py3.14 (with numpy fix): https://github.com/ROCm/TheRock/actions/runs/23516828149/job/68451129501 Latest after this merge - ROCm/pytorch#3100: https://github.com/ROCm/TheRock/actions/runs/23546731231/job/68549058264 ## Related - Fixes #2640 - Supersedes #2783 - Tracks #2985 ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
chiranjeevipattigidi
pushed a commit
to ROCm/TheRock
that referenced
this pull request
Mar 27, 2026
## Summary - Add Python 3.14 to the PyTorch release workflow matrices for release/2.9, release/2.10, and nightly - Add `cp314` to the S3 dependency index allowlist so third-party wheels (numpy, etc.) are uploaded for Python 3.14 - Update RELEASES.md to document Python 3.14 support ## Dependency chain This PR depends on the following being merged first: 1. **TheRock** #3540 2. **ROCm/pytorch** ROCm/pytorch#3099 3. **ROCm/pytorch** ROCm/pytorch#3100 The ROCm/pytorch PRs fix `numpy==2.1.2` having no cp314 wheels, which causes the build to fail when pip falls back to a source build under sccache/meson. ## Python 3.14 support matrix | PyTorch version | Python 3.14 support | |-----------------|---------------------| | 2.8 | Not supported | | 2.9 | Supported | | 2.10 | Supported | | nightly | Supported | ## Changes - `release_portable_linux_pytorch_wheels.yml` — add py3.14 include entries for release/2.9, release/2.10, nightly - `release_windows_pytorch_wheels.yml` — add py3.14 to the version list - `update_dependencies.py` — add `cp314` to `_ALLOWED_CPYTHON_TAGS` - `RELEASES.md` — update supported Python versions ## Test results - Nightly py3.14 (already passing): https://github.com/ROCm/TheRock/actions/runs/23488558012/job/68350335178 - release/2.9 py3.14 (with numpy fix): https://github.com/ROCm/TheRock/actions/runs/23516862647/job/68451235656 Latest after this merge - ROCm/pytorch#3099: https://github.com/ROCm/TheRock/actions/runs/23546615437/job/68548629107 - release/2.10 py3.14 (with numpy fix): https://github.com/ROCm/TheRock/actions/runs/23516828149/job/68451129501 Latest after this merge - ROCm/pytorch#3100: https://github.com/ROCm/TheRock/actions/runs/23546731231/job/68549058264 ## Related - Fixes #2640 - Supersedes #2783 - Tracks #2985 ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
numpy==2.1.2has no cp314 wheels on PyPI, causing Python 3.14 builds in TheRock CI to fail with a meson/sccache error when pip falls back to building numpy from sourcepython_versionmarkers to usenumpy==2.4.3for Python 3.14+, while keeping the existingnumpy==2.1.2pin for older Python versionsMotivation
Test Result
Submission Checklist