[ROCm][release/2.12] Skip profiler check for foreach tests on ROCm (ROCM-21749)#3262
Merged
Merged
Conversation
…749) ROCm's profiler (ROCTracer/rocprofiler) uses different kernel naming than CUDA's Kineto profiler. The multi_tensor_apply_kernel symbol never appears in ROCm profiler output, causing test_big_num_tensors to fail with spurious AssertionError on all ROCm GPUs. Add TEST_WITH_ROCM to the skip_profiler_check guard so the profiler- based fast-path assertion is bypassed on ROCm, matching the existing skip for CUDA 12.6/12.8 flakiness.
|
Jenkins build for 305c71767a71be234bdd2014d09c8b8fe029118f commit finished as FAILURE |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes ROCM-21749:
test_big_num_tensors__foreach_normfails on all ROCm GPUs.Root Cause
ForeachFuncWrapper.__call__profiles a_foreach_normcall and checks formulti_tensor_apply_kernelin profiler output to verify the multi-tensor fast-path was taken. On CUDA, Kineto captures demangled kernel names likemulti_tensor_apply_kernel[...]. On ROCm, ROCTracer/rocprofiler captures different symbols (hipLaunchKernel,vectorized_elementwise_kernel, etc.), somta_calledis alwaysFalseand the assertion fails.Fix
Add
or TEST_WITH_ROCMtoskip_profiler_checkso the profiler-based assertion is bypassed on ROCm, consistent with the existing skip for CUDA 12.6/12.8 flakiness.Test Plan
test_big_num_tensors__foreach_norm_*should now pass on ROCm GPUs (MI210, MI300X, MI350X)Jira: https://amd-hub.atlassian.net/browse/ROCM-21749