Skip to content

Add support for new augmentations in rocAL - Group 3#438

Merged
kiritigowda merged 100 commits into
ROCm:developfrom
fiona-gladwin:rocal_vx_rpp_set3
Feb 9, 2026
Merged

Add support for new augmentations in rocAL - Group 3#438
kiritigowda merged 100 commits into
ROCm:developfrom
fiona-gladwin:rocal_vx_rpp_set3

Conversation

@fiona-gladwin
Copy link
Copy Markdown
Contributor

Motivation

Integrates eight new RPP (Radeon Performance Primitives) kernel augmentations into rocAL: Ricap, Remap, Erase, CropAndPatch, Bitwise AND, OR, NOT and EXOR.

Technical Details

  • Added eight new augmentation kernels with both fixed and parameterized variants
  • Implemented C++ node classes for each augmentation with proper initialization and update methods
  • Exposed Python bindings for all new augmentations

Test Plan

  • Run testAllScript.sh and unit_tests.sh to ensure all the tests are running

Associated MIVisionX PR #1596
NOTE : To be merged after PR #437

Change copyright
Add unit tests for NonLinearBlend, Gaussian and Median filters
Dilate
Erode
Magnitude
Phase
Remove per-iter updation of perspective array
Add unit test for WarpPerspective
Remove ThresholdFixed
Modify params to accept vector
@LakshmiKumar23
Copy link
Copy Markdown
Contributor

@fiona-gladwin can you please resolve merge conflicts? Thanks!

@fiona-gladwin
Copy link
Copy Markdown
Contributor Author

@fiona-gladwin can you please resolve merge conflicts? Thanks!

Done @LakshmiKumar23

@LakshmiKumar23 LakshmiKumar23 self-requested a review January 21, 2026 17:36
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 21, 2026

Codecov Report

❌ Patch coverage is 81.47590% with 123 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../augmentations/filter_augmentations/node_erase.cpp 64.29% 80 Missing ⚠️
rocAL/source/api/rocal_api_augmentation.cpp 87.04% 14 Missing ⚠️
...ugmentations/geometry_augmentations/node_ricap.cpp 90.57% 10 Missing ⚠️
...ons/geometry_augmentations/node_crop_and_patch.cpp 90.72% 9 Missing ⚠️
...ugmentations/geometry_augmentations/node_remap.cpp 90.82% 9 Missing ⚠️
...ntations/filter_augmentations/node_bitwise_ops.cpp 96.55% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #438      +/-   ##
===========================================
+ Coverage    79.52%   79.58%   +0.06%     
===========================================
  Files          294      300       +6     
  Lines        22723    23401     +678     
===========================================
+ Hits         18070    18623     +553     
- Misses        4653     4778     +125     
Files with missing lines Coverage Δ
rocAL/include/api/rocal_api_types.h 0.00% <ø> (ø)
...mentations/filter_augmentations/node_bitwise_ops.h 100.00% <100.00%> (ø)
rocAL/include/pipeline/commons.h 100.00% <ø> (ø)
rocAL/include/pipeline/tensor.h 71.76% <ø> (ø)
...ntations/filter_augmentations/node_bitwise_ops.cpp 96.55% <96.55%> (ø)
...ons/geometry_augmentations/node_crop_and_patch.cpp 90.72% <90.72%> (ø)
...ugmentations/geometry_augmentations/node_remap.cpp 90.82% <90.82%> (ø)
...ugmentations/geometry_augmentations/node_ricap.cpp 90.57% <90.57%> (ø)
rocAL/source/api/rocal_api_augmentation.cpp 84.20% <87.04%> (+0.17%) ⬆️
.../augmentations/filter_augmentations/node_erase.cpp 64.29% <64.29%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread tests/cpp_api/unit_tests/unit_tests.cpp Outdated
Copy link
Copy Markdown
Collaborator

@rrawther rrawther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments. Need proper documentation and example

Comment thread rocAL/source/augmentations/filter_augmentations/node_erase.cpp Outdated
Comment thread rocAL/source/augmentations/filter_augmentations/node_erase.cpp
Comment thread rocAL/source/augmentations/filter_augmentations/node_erase.cpp Outdated
Comment thread rocAL/source/augmentations/filter_augmentations/node_erase.cpp
@fiona-gladwin
Copy link
Copy Markdown
Contributor Author

@LakshmiKumar23 @rrawther Addressed all comments please check

@LakshmiKumar23
Copy link
Copy Markdown
Contributor

/Azurepipelines run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@LakshmiKumar23
Copy link
Copy Markdown
Contributor

@kiritigowda kiritigowda merged commit 16429b3 into ROCm:develop Feb 9, 2026
1 of 4 checks passed
@fiona-gladwin fiona-gladwin deleted the rocal_vx_rpp_set3 branch February 24, 2026 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants