drops float precision for large N asum,nrm2#717
Merged
Conversation
daineAMD
approved these changes
Sep 24, 2019
assistant-librarian Bot
pushed a commit
that referenced
this pull request
Jul 17, 2025
[rocBLAS] Docs: Correct Windows filename (#717) Correct the windows filename that was erroneously changed in an earlier update.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of proposed changes for pre-checkin test failure:
Tests with large N for single precision accumulation functions got accidentally put in with a merge
Removes large N single precision pre-checkin tests on asum, nrm2 rather than increase tolerance, keeps all other data types with large N and still checks single precision in other tests