Skip to content

Conversation

@kiritigowda
Copy link
Collaborator

Motivation

Host package is only created if all dependencies are meet

Technical Details

Separate host module from runtime and dev package

Test Plan

All current CTests

Test Result

Ctests should pass

Submission Checklist

@kiritigowda kiritigowda added enhancement New feature or request ci:precheckin run mainline precheckin CI job labels Nov 7, 2025
@kiritigowda
Copy link
Collaborator Author

@AryanSalmanpour

CPack: - Install project: rocdecode []
CPack: -   Install component: runtime
CPack: -   Install component: dev
CPack: -   Install component: test
CPack: -   Install component: host
CPack: Create package
CPack: - package: /var/jenkins_home/workspace/line_precheckin_rocDecode_PR-671/j22vLeaSK/rocdecode/build/release/rocdecode-dev_1.5.1-local_amd64.deb generated.
CPack: - package: /var/jenkins_home/workspace/line_precheckin_rocDecode_PR-671/j22vLeaSK/rocdecode/build/release/rocdecode-host_1.5.1-local_amd64.deb generated.
CPack: - package: /var/jenkins_home/workspace/line_precheckin_rocDecode_PR-671/j22vLeaSK/rocdecode/build/release/rocdecode_1.5.1-local_amd64.deb generated.
CPack: - package: /var/jenkins_home/workspace/line_precheckin_rocDecode_PR-671/j22vLeaSK/rocdecode/build/release/rocdecode-test_1.5.1-local_amd64.deb generated.

Copy link
Contributor

@spolifroni-amd spolifroni-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kiritigowda what is the rocDecode-host package used for?

At the top of the package installation topic there's a description of the packages, and the host package doesn't seem to have been added there.

Copy link
Contributor

@spolifroni-amd spolifroni-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This actually needs a changelog entry. I missed that the first time I looked.

@kiritigowda
Copy link
Collaborator Author

@AryanSalmanpour can we merge this?

@kiritigowda kiritigowda merged commit 433ca3a into ROCm:develop Nov 14, 2025
7 of 9 checks passed
@kiritigowda kiritigowda deleted the kg/rocdecode-host-pkg branch November 14, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:precheckin run mainline precheckin CI job enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants