Skip to content

Conversation

@justinrosner
Copy link
Contributor

@justinrosner justinrosner commented Sep 2, 2025

Motivation

This PR addresses the issue identified in Navi2X LIT tests: https://github.com/ROCm/rocMLIR-internal/issues/1976

Technical Details

The lit.local.cfg that was added for mixr-gemm-gemm tests (found here: mlir/test/fusion/e2e/mixr-gemm-gemm/lit.local.cfg) wasn't properly being picked up by the LIT test infrastructure. This was leading to the config.unsupported not being run, and the two tests mentioned in the issue failing. The fix for this is to update mlir/test/fusion/e2e/lit.local.cfg so that we are using config.excludes to not run the entire directory of mixr-gemm-gemm tests.

Test Plan

  • LIT tests on Navi2X
  • LIT tests on the CI

Test Result

  • LIT tests on Navi2X
  • LIT tests on the CI

Submission Checklist

@codecov
Copy link

codecov bot commented Sep 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1968      +/-   ##
===========================================
+ Coverage    79.50%   79.62%   +0.11%     
===========================================
  Files          100      102       +2     
  Lines        31016    31910     +894     
  Branches      4819     5047     +228     
===========================================
+ Hits         24659    25406     +747     
- Misses        4245     4312      +67     
- Partials      2112     2192      +80     
Flag Coverage Δ
mfma 79.62% <ø> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 50 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@umangyadav umangyadav merged commit 609d77f into develop Sep 2, 2025
17 of 23 checks passed
@umangyadav umangyadav deleted the justin-navi2-tests branch September 2, 2025 22:15
@justinrosner justinrosner mentioned this pull request Sep 3, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants