Skip to content

Conversation

@dhernandez0
Copy link
Contributor

Motivation

This workaround was introduced for gfx11 here: #1699

This is likely a backend bug that has been fixed.

closes: https://github.com/ROCm/rocMLIR-internal/issues/1661

Technical Details

Remove workaround and its test.

Test Plan

e2e tests were added in #1699 that check if this works. Make sure the tests pass.

Test Result

Test pass.

Submission Checklist

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts a workaround that was implemented for gfx11 architecture to address a backend bug that has since been fixed. The change removes forced unrolling behavior and associated test code that was added as a temporary measure.

Key changes:

  • Removes the isGfx11 parameter and conditional logic from the createFirstGemmNegInfPadding function
  • Restores forceUnroll=true behavior for all architectures
  • Removes the test case specifically designed to validate the gfx11 workaround

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
mlir/test/Dialect/Rock/gridwise_attention_accel_lowering.mlir Removes test case for gfx11 workaround validation
mlir/lib/Dialect/Rock/Transforms/GridwiseGemmToBlockwise.cpp Removes gfx11-specific parameter and logic, restores original forceUnroll behavior

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@justinrosner justinrosner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me

@umangyadav
Copy link
Member

@djramic could this be an issue with the upstream merge failing on navi3x ?

@dhernandez0 dhernandez0 force-pushed the revert_gfx11_workaround_createFirstGemmNegInfPadding branch from 999b2e0 to adef6f1 Compare September 19, 2025 13:52
@umangyadav umangyadav merged commit c9475f1 into develop Sep 19, 2025
8 of 15 checks passed
@umangyadav umangyadav deleted the revert_gfx11_workaround_createFirstGemmNegInfPadding branch September 19, 2025 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants