Skip to content

Conversation

@justinrosner
Copy link
Contributor

@justinrosner justinrosner commented Nov 17, 2025

Motivation

This PR pulls down a commit from Upstream LLVM to fix a crash that we were seeing when running the weekly tuning

Fixes: https://github.com/ROCm/rocMLIR-internal/issues/2116

Technical Details

See the linked upstream PR for a full description of the fix.

Test Plan

  • Manually run failing design
  • PR CI

Test Result

  • Manual running of failing design
  • PR CI

Submission Checklist

Copy link
Contributor

@dhernandez0 dhernandez0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could you add a rocmlir CI test if there's one that fails?

@justinrosner justinrosner force-pushed the justinr-scavenge-error branch from 10c6bcf to 521747c Compare November 17, 2025 16:17
@justinrosner
Copy link
Contributor Author

@justinrosner justinrosner merged commit f83e36f into develop Nov 17, 2025
14 checks passed
@justinrosner justinrosner deleted the justinr-scavenge-error branch November 17, 2025 20:17
@umangyadav umangyadav mentioned this pull request Dec 11, 2025
12 tasks
@umangyadav umangyadav mentioned this pull request Dec 18, 2025
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants