[URGENT] Bring back commented param sw for conv structure and perf#2344
[URGENT] Bring back commented param sw for conv structure and perf#2344dorde-antic merged 1 commit intodevelopfrom
Conversation
There was a problem hiding this comment.
Code Review
The change is straightforward and correct — restoring two previously-commented-out parameterSweep calls that were accidentally left disabled after Attention Parameter Sweep testing.
What the change does:
- Uncomments
parameterSweep("conv_structure")andparameterSweep("perf_config")inside the "Parameter Sweep" stage of the weekly Jenkins matrix. - These calls use the default sweep type, which runs
python3 ./bin/parameterSweeps.py -j ${limit_lit_workers} ${CONFIG} --log-failures.
One thing worth noting:
The "Parameter Sweep" stage lives inside a matrix that iterates over all six codepaths (mfma, vanilla, navi21, navi3x, navi4x, gfx950). Since parameterSweep("conv_structure") and parameterSweep("perf_config") do not use the CODEPATH variable, they will execute the same sweep script six times (once per matrix row). This appears to be the pre-existing behavior that was in place before the lines were commented out, so this PR restores it faithfully — but it is worth confirming that running these config-agnostic sweeps once per codepath is intentional and not an accidental duplication from when the matrix was introduced.
No functional issues with the change itself. The skip-ci label is appropriate since this only modifies the CI pipeline definition.
Sent by Cursor Automation: Djordje’s Automation
| //parameterSweep("conv_structure") | ||
| //parameterSweep("perf_config") | ||
| parameterSweep("conv_structure") | ||
| parameterSweep("perf_config") |
There was a problem hiding this comment.
Since this stage runs inside the CODEPATH matrix (over mfma, vanilla, navi21, navi3x, navi4x, gfx950), both parameterSweep("conv_structure") and parameterSweep("perf_config") will execute six times — once per matrix row — running the same command each time because neither call uses the CODEPATH variable.
If the intent is to run these sweeps only once (codepath-independent), they could be moved to a separate non-matrix stage. If the current behavior (6× execution) is intentional and was how it worked before being commented out, this is fine to merge as-is.
umangyadav
left a comment
There was a problem hiding this comment.
Make sure weekly passes for merging this
|
@umangyadav we already had this on develop (until few days ago) and weekly passed with it, |


Motivation
It was commented out for testing purposes of Attention Parameter Sweeps and wasn't uncommented.
Technical Details
Uncommented
Test Plan
No need to wait for CI checks, lets merge this asap so that all param sw steps are kicked on weekly.
Test Result