Fix the hip free error in the ctest and samples#249
Merged
kiritigowda merged 13 commits intoROCm:developfrom Oct 9, 2025
Merged
Fix the hip free error in the ctest and samples#249kiritigowda merged 13 commits intoROCm:developfrom
kiritigowda merged 13 commits intoROCm:developfrom
Conversation
rrawther
reviewed
Oct 3, 2025
rrawther
requested changes
Oct 3, 2025
Contributor
rrawther
left a comment
There was a problem hiding this comment.
Please add enum for mem_types for better readability
Contributor
Author
|
The CI check should pass in this PR, the fix addresses the failure that used to happen in ctest and cause the CI build to exit. |
Contributor
Author
I added enum(s) for all mem_types in the latest commit. |
Collaborator
|
@essamROCm failing CI |
Collaborator
Collaborator
|
Collaborator
|
Passing Azure CI - |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #249 +/- ##
===========================================
+ Coverage 42.85% 43.28% +0.44%
===========================================
Files 12 12
Lines 1202 1213 +11
===========================================
+ Hits 515 525 +10
- Misses 687 688 +1
🚀 New features to boost your workflow:
|
AryanSalmanpour
approved these changes
Oct 8, 2025
rrawther
reviewed
Oct 8, 2025
rrawther
reviewed
Oct 8, 2025
rrawther
reviewed
Oct 9, 2025
kiritigowda
approved these changes
Oct 9, 2025
jharryma
pushed a commit
that referenced
this pull request
Oct 10, 2025
* ROCm 7.1 - updates and fixes to changelog (#252) * [Ex CI] Enable PipelineRepoRef parameter (#251) Co-authored-by: Kiriti Gowda <kiriti.nageshgowda@amd.com> * [Ex CI] Added Ref to repositories (#254) * Bugfix - hip free error in the ctest and samples (#249) * Fix the hip free error in the ctest and samples * Change all mem types values to meaningful ENUM * Print GPU info when GPU is used only * Correct sample params remove resize add mem type HOST * Comment the testjpegbatched for now till we debug its root cause of failure * Comment all_other_decoder_apis test for now till we debug its root cause of failure * Comment rocpydecode_test_decodercpu test for now till we debug its root cause of failure * Comment the ffmpeg for now till we debug its root cause of failure * Comment the ffmpeg torch for now till we debug its root cause of failure * Replacing mem_type values with enum * Setup - Adding numpy as prerequisite (#248) * Adding numpy as requirment for tests and samples * Added numpy changes to the change log --------- Co-authored-by: Kiriti Gowda <kiriti.nageshgowda@amd.com> --------- Co-authored-by: amd-hsivasun <hsivasun@amd.com> Co-authored-by: essamROCm <77812857+essamROCm@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix the HIP Free error seen in the ctest and ffmpeg samples
Technical Details
Specifying the host mem type for ffmpeg host cpu decoding
Test Plan
ctest passes, samples were tested