Update google benchmark version #545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umfranzw
requested review from
RobsonRLemos,
lawruble13 and
stanleytsang-amd
as code owners
NguyenNhuDi
approved these changes
May 8, 2025
We are now using some newer google benchmark features that are not present in 1.8.0. Update the cmake dependencies file to pull version 1.9.0.
umfranzw
force-pushed
the
update_gbench_version
branch
from
2baa844 to
20014ff
Compare
Collaborator
Author
|
Thanks @NguyenNhuDi - I've added a note about this to the changelog. |
stanleytsang-amd
approved these changes
May 9, 2025
spolifroni-amd
approved these changes
May 9, 2025
umfranzw
added a commit
to umfranzw/rocThrust
that referenced
this pull request
Jun 4, 2025
We are now using some newer google benchmark features that are not present in 1.8.0. Update the cmake dependencies file to pull version 1.9.0.
shahamed
pushed a commit
that referenced
this pull request
Jun 11, 2025
We are now using some newer google benchmark features that are not present in 1.8.0. Update the cmake dependencies file to pull version 1.9.0.
jharryma
pushed a commit
that referenced
this pull request
Jun 12, 2025
ammallya
pushed a commit
that referenced
this pull request
Oct 28, 2025
We are now using some newer google benchmark features that are not present in 1.8.0. Update the cmake dependencies file to pull version 1.9.0. [ROCm/rocThrust commit: cf22cb3]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are now using some newer google benchmark features that are not present in 1.8.0. Update the cmake dependencies file to pull version 1.9.0.