Skip to content

Conversation

@r-abishek
Copy link
Member

Add ffts license

@r-abishek r-abishek requested review from Copilot and kiritigowda June 9, 2025 21:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds the FFTS license file and updates the CMake build scripts to include it in packaged artifacts.

  • Introduce third_party/ffts/FFTS_LICENSE containing the third-party FFTS license text
  • Define a new CPack variable and two install rules in CMakeLists.txt to package the FFTS license alongside existing licenses

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
third_party/ffts/FFTS_LICENSE Added the FFTS BSD-style license file
CMakeLists.txt Registered and installed FFTS_LICENSE in CPack targets
Comments suppressed due to low confidence (1)

third_party/ffts/FFTS_LICENSE:6

  • [nitpick] Indentation in the license clauses mixes tabs and spaces. Consider standardizing to a single style (either all tabs or all spaces) for consistency and readability.
* Redistributions of source code must retain the above copyright

@kiritigowda kiritigowda self-assigned this Jun 9, 2025
@kiritigowda
Copy link
Collaborator

+ rpm -qlp package/rhel9-rpp.rpm
/opt/rocm
/opt/rocm/lib
/opt/rocm/lib/librpp.so.2
/opt/rocm/lib/librpp.so.2.0.0
/opt/rocm/share
/opt/rocm/share/doc
/opt/rocm/share/doc/rpp
/opt/rocm/share/doc/rpp/FFTS_LICENSE
/opt/rocm/share/doc/rpp/LICENSE

@kiritigowda
Copy link
Collaborator

Merge pending package build phase

@kiritigowda kiritigowda merged commit 5b35d1e into ROCm:develop Jun 10, 2025
0 of 4 checks passed
ManasaDattaT pushed a commit to ManasaDattaT/rpp that referenced this pull request Dec 19, 2025
* Create FFTS_LICENSE

* Update CMakeLists.txt

---------

Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants