Skip to content

Conversation

@mmakevic-amd
Copy link

The fix was originally upstreamed to XLA by @hsharsha in openxla/xla#17544, but Copybara did not apply the changes to TensorFlow correctly.

This will be cherry-picked to r2.18-rocm-enhanced, r2.17-rocm-enhanced, and develop-upstream

@mmakevic-amd
Copy link
Author

Other PRs are here:
develop-upstream -> #2995
r2.18-rocm-enhanced -> #2997
r2.17-rocm-enhanced -> #2998

Copy link
Collaborator

@i-chaochen i-chaochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@i-chaochen
Copy link
Collaborator

but Copybara did not apply the changes to TensorFlow correctly.

@mmakevic-amd wondering does it mean we need to upstream it tensorflow? otherwise this change on our local will be wiped out at next weekly-sync?

@mmakevic-amd
Copy link
Author

but Copybara did not apply the changes to TensorFlow correctly.

@mmakevic-amd wondering does it mean we need to upstream it tensorflow? otherwise this change on our local will be wiped out at next weekly-sync?

Yes, we would have conflicts in sync because of this every time.. I will open a PR to the upstream. Who should I ping for review?

@i-chaochen
Copy link
Collaborator

but Copybara did not apply the changes to TensorFlow correctly.

@mmakevic-amd wondering does it mean we need to upstream it tensorflow? otherwise this change on our local will be wiped out at next weekly-sync?

Yes, we would have conflicts in sync because of this every time.. I will open a PR to the upstream. Who should I ping for review?

I think you can just ping beckerhe who is the original PR review for Harsha's previous PR in XLA, and let him know TF side doesn't port that code from Copybara.

@mmakevic-amd mmakevic-amd merged commit 1260c54 into r2.19-rocm-enhanced Jun 15, 2025
1 of 4 checks passed
@mmakevic-amd mmakevic-amd deleted the pass_arch_to_crosstool branch June 15, 2025 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants