Skip to content

Minor updates for the cover art scripts#436

Merged
ROpdebee merged 3 commits intomainfrom
cover-art-updates
May 19, 2022
Merged

Minor updates for the cover art scripts#436
ROpdebee merged 3 commits intomainfrom
cover-art-updates

Conversation

@kellnerd
Copy link
Copy Markdown
Collaborator

Various minor improvements for ECAU and supercharged cover art edits, based on the suggestions by chaban in the forums.

  • Support new packaging types (one of them is non-square) and release statuses for supercharged cover art edits
  • Use the latest version of Image Max URL for compatibility with new Violentmonkey (beta) versions (untested)
  • Support filenames on archive.org which require URL encoding in ECAU:
    • New test for the given example to cover this case.
    • I'm restoring path separators after URL encoding to be on the safer side, although I haven't seen examples for full paths "including directory paths" yet, as per
      name: string; // For files in subdirectories, this will contain the full path including directory paths.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2022

Codecov Report

Merging #436 (d04c251) into main (8a9aa86) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #436   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           44        44           
  Lines          994       994           
  Branches       166       166           
=========================================
  Hits           994       994           
Impacted Files Coverage Δ
...mb_enhanced_cover_art_uploads/providers/archive.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a9aa86...d04c251. Read the comment docs.

@ROpdebee ROpdebee merged commit 207c8ef into main May 19, 2022
@ROpdebee
Copy link
Copy Markdown
Owner

Thanks!

@github-actions
Copy link
Copy Markdown

🚀 Released 1 new userscript version(s):

  • mb_enhanced_cover_art_uploads 2022.5.19 in 030a108

github-actions Bot added a commit that referenced this pull request May 19, 2022
Minor updates for the cover art scripts (#436)
@kellnerd kellnerd deleted the cover-art-updates branch May 19, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants