-
Notifications
You must be signed in to change notification settings - Fork 0
BREAKING: Arch proposal #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit tests require these methods -> they must stay being visible inside a package
isOkValueNull, isErrorValueNull
co012
reviewed
Apr 13, 2022
co012
reviewed
Apr 13, 2022
configurations/unit-test-configuration/locations/location-2/location-2.json
Outdated
Show resolved
Hide resolved
co012
reviewed
Apr 13, 2022
co012
reviewed
Apr 13, 2022
co012
reviewed
Apr 13, 2022
co012
reviewed
Apr 13, 2022
co012
reviewed
Apr 13, 2022
co012
reviewed
Apr 13, 2022
co012
reviewed
Apr 13, 2022
co012
approved these changes
Apr 13, 2022
Collaborator
co012
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jednak przepchołeść te 2 spacje
Collaborator
Author
|
Nie, konfigurację lintera ustalimy jak zrobimy sobie jakieś spotkanie. Ja na razie nic nie ustawiałem, po prostu przekleiłem Java Style by Google. Edit: Ale 2 spacje >> 4 spacje wcięcia xD |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Proposal of the new architecture
How it works
Initializerclass intoGameclassGameclass holds reference toControllerand is main class of our application. It was separated from the controller to make menu addition possible (it should be happening there)Controllerholds references to currentLocationModel(which holds all the logical state concerning location being currently displayed) & currentLocationView(which holds all the data needed for representation of model).LocationViewadditionaly (as aScenesubclass) is responsible for collecting user keyboard input. When it receives one, it passes it to the controller viaobserver pattern. Controller then decides what to do (updates model -> model notifies view).GameObjectVieware responsible for collecting user mouse input. If one is collected it is passed to controller viaobserver pattern.Controlleris responsible for updating the model basing on input it receives.Modelafter update notifiesViewso the latter can update itself.This way we achieve almost Model-View-Controller pattern!