@mhawryluk/rpg 82 points popup refactor #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- class responsible for creating and controlling popups, currently only handles PointsEarnedPopup
kkafar
approved these changes
Apr 23, 2022
Collaborator
kkafar
left a comment
kkafar
left a comment
There was a problem hiding this comment.
Looks good to me.
I left some cosmetic suggestions.
And just a note for the future: we might consider creating stage "on demand" (not keeping it in memory for all the time). The same thing applies to object creation (right now all the in-game objects are created when the game gets initialized).
Co-authored-by: Kacper Kafara <kacperkafara@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created PopupController that is used to manage popups. Popups are now extending Scene class and the PopupController contains a singular scene.
Checklist