chore: update before merging #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkafar
added a commit
that referenced
this pull request
Apr 24, 2022
* chore: allow for creation of different object types
* refact: newline at object-1 file end
* chore: add JavaDoc comments for MouseClickedEvent
* chore: add JavaDoc comments for KeyboardEvent
* chore: add JavaDoc comments for GameObjectStateChange
* chore: add JavaDocs comments for LocationModelStateChange
* chore: style update
* chore: make Initializer#mainStage field final
mainStage is coming as a constructor parameter and it is entry stage
provided by JavaFX. We do not change, and we do not want to change this
reference anywhere.
* chore: remove INTERACTIVE from GameObject.Type enum options
We do not intent to instantiate abstract InteractiveGameObject type.
Only more specific types should be instantiated.
* refact: move GameObject construction to separate factory class & methods
* chore: add GameObjectViewFactory class & methods
This aims to extract the object creation logic from LocationView class
* chore: add builder for LocationModel
This aims to extract the creation logic to separate class to make object
injection possible. (Object injection is needed as we need register view
to model)
* fix: LocationModel builder methods
* chore: add non null assertion in LocationModel.Builder#setTag method
* chore: register GameObjectViews to their model classses!
* fix: convert game object type string to uppercase in factory method
* fix: remove "interactive" type from configuration types
* chore: update before merging (#19)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist