chore: Create initial setup for Java app #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkafar
commented
Mar 22, 2022
build.gradle
Outdated
Comment on lines
41
to
48
| // implementation('net.synedra:validatorfx:0.1.13') { | ||
| // exclude(group: 'org.openjfx') | ||
| // } | ||
| implementation('org.kordamp.ikonli:ikonli-javafx:12.3.0') | ||
| implementation('org.kordamp.bootstrapfx:bootstrapfx-core:0.4.0') | ||
| // implementation('eu.hansolo:tilesfx:17.1.5') { | ||
| // exclude(group: 'org.openjfx') | ||
| // } |
Collaborator
Author
There was a problem hiding this comment.
The project did not build successfully with these two dependencies. Had to cut them out. Don't think we will need them. Even if so, we can figure it out later on.
* chore: Setup project build on CI * chore: Update CI build script * chore: Configure CI build * chore: Change java vendor on CI * chore: Use gradle cache on CI
co012
reviewed
Mar 24, 2022
co012
reviewed
Mar 24, 2022
co012
reviewed
Mar 24, 2022
Collaborator
co012
left a comment
co012
left a comment
There was a problem hiding this comment.
Why did you use javafx version 15.0.1 (There are newer versions).
Collaborator
Author
|
I upgraded gradle to 7.4.1 (latest up to date) & JavaFX to 17.0.2 (latest LTS version). BTW. You can see below that our CI works! :D |
mhawryluk
approved these changes
Mar 26, 2022
Collaborator
mhawryluk
left a comment
mhawryluk
left a comment
There was a problem hiding this comment.
I managed to run the app on my computer, so seems good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add initial setup for Java application with JavaFX -- we can change it later on, if we decide to go with different technology