chore: associate action emitter with action #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkafar
force-pushed
the
@kkafar/bounded-object-action-creation
branch
from
8b70bb9 to
f9f48d9
Compare
kkafar
changed the title
ksiek127
approved these changes
Jun 4, 2022
Collaborator
ksiek127
left a comment
ksiek127
left a comment
There was a problem hiding this comment.
nie odpalałem ale wygląda dobrze
kkafar
force-pushed
the
@kkafar/docs-battle-action
branch
from
d78c0ee to
d7860a8
Compare
This required some refactoring and allowed me to improve object creation code & simplify battle action creation
kkafar
force-pushed
the
@kkafar/bounded-object-action-creation
branch
from
f9f48d9 to
2d2eaec
Compare
This was referenced Jun 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Associated action emitter with action. This required some refactoring and allowed me to improve object creation code & simplify battle action creation.
What changed:
Action contains reference to the object that emitted it.
Should be merged after #77 is merged or closed.
Fixes #55
Checklist