Add back the AbstractTemplate.zoneId field so XStream can reference it #5287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwvanderlinde
force-pushed
the
bugfix/5285-guid-references
branch
from
ef6de00 to
2ebb256
Compare
After loading, null it out so we don't keep serializing it and it won't be the target of a reference in the future.
kwvanderlinde
force-pushed
the
bugfix/5285-guid-references
branch
from
2ebb256 to
392beeb
Compare
cwisniew
requested changes
Mar 17, 2025
cwisniew
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Fixes #5285
Description of the Change
Adds back the
AbstractTemplate.zoneId. XStream likes to use it as a target for references pre-1.16, but can't find the value back if the field is removed.We null it out in
readResolve()so the field isn't serialized going forward and won't be the target of a reference.Possible Drawbacks
None
Documentation Notes
N/A
Release Notes
This change is