1.16 - Fix bad FoW check in PointerTool#5309
Merged
cwisniew merged 3 commits intoRPTools:release-1.16from Mar 25, 2025
Merged
Conversation
Every other part of token dragging measures against the anchor, and this discrepency meant the FoW checks were not checking the correct position.
This lets rendering still be done smoothly, but validation is done "cell by cell" even when the preference is disabled.
StampTool doesn't have the same issue as PointerTool since it doesn't validation drags, but we might as well keep the structure as similar as possible.
cwisniew
approved these changes
Mar 25, 2025
cwisniew
approved these changes
Mar 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Fixes #5308
Description of the Change
This fixes two issues with
PointerTool:StampToolwas updated in a similar way to stay as much in line withPointerToolas possible, even though it doesn't have the same underlying issue due to not validating stamp moves.Possible Drawbacks
None
Documentation Notes
N/A
Release Notes
This change is