Skip to content

Conversation

@bubblobill
Copy link
Collaborator

@bubblobill bubblobill commented May 7, 2025

Identify the Bug or Feature request

You can link a pull request to an issue with one of
addresses #5353
#5353 (comment)

Description of the Change

Fixed duplicate key name in preferences

Possible Drawbacks

none

Documentation Notes

n/a

Release Notes

n/a


This change is Reviewable

@cwisniew cwisniew added this pull request to the merge queue May 9, 2025
@cwisniew cwisniew removed this pull request from the merge queue due to a manual request May 9, 2025
@cwisniew
Copy link
Member

cwisniew commented May 9, 2025

@kwvanderlinde I think he addressed what you asked but he may also be trying to pull a fast one :) so do you want to check as well?

@kwvanderlinde
Copy link
Collaborator

@kwvanderlinde I think he addressed what you asked but he may also be trying to pull a fast one :) so do you want to check as well?

I think you're right 😄

AffineTransform at = gc.getNormalizingTransform();
at.concatenate(SCROLL_TRANSFORM);
g2d.transform(at);
AffineTransform at;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsed var at

<member id="b5ac9"/>
<member id="e89bc"/>
</group>
</buttonGroups>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a stowaway. Is it doing anything?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a radio button group for the scroll mode but they were definitely removed.

public static final NumericPreference<Double> scrollStatusEndPause =
DoubleType.create("statusBarDelay", 1.8);
public static final Preference<Double> scrollStatusEndPause =
DoubleType.create("scrollStatusEndPause", 1.8);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't these stay as NumericPreference<Double>?

public static final Preference<Boolean> statusScrollNormalisingTransform =
BooleanType.create("statusScrollNormalisingTransform", false);
public static final Preference<Boolean> statusScrollDoubleBuffered =
BooleanType.create("statusScrollDoubleBuffered", true);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these temporary preferences meant to still be here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Until you get something that works

@bubblobill
Copy link
Collaborator Author

I got sidetracked by the whole IDE failing to work after the GDX commit.

This will be converted to draft when I get back to my computer.

Currently trying to find render settings that will satisfy @kwvanderlinde desire for no artifacts and actually being visible on screen changes.

1 similar comment
@bubblobill
Copy link
Collaborator Author

I got sidetracked by the whole IDE failing to work after the GDX commit.

This will be converted to draft when I get back to my computer.

Currently trying to find render settings that will satisfy @kwvanderlinde desire for no artifacts and actually being visible on screen changes.

@bubblobill bubblobill marked this pull request as draft May 10, 2025 09:25
@bubblobill bubblobill closed this May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants