-
Notifications
You must be signed in to change notification settings - Fork 274
Fixed bad preference keyname #5414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@kwvanderlinde I think he addressed what you asked but he may also be trying to pull a fast one :) so do you want to check as well? |
I think you're right 😄 |
| AffineTransform at = gc.getNormalizingTransform(); | ||
| at.concatenate(SCROLL_TRANSFORM); | ||
| g2d.transform(at); | ||
| AffineTransform at; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsed var at
| <member id="b5ac9"/> | ||
| <member id="e89bc"/> | ||
| </group> | ||
| </buttonGroups> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a stowaway. Is it doing anything?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was a radio button group for the scroll mode but they were definitely removed.
| public static final NumericPreference<Double> scrollStatusEndPause = | ||
| DoubleType.create("statusBarDelay", 1.8); | ||
| public static final Preference<Double> scrollStatusEndPause = | ||
| DoubleType.create("scrollStatusEndPause", 1.8); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't these stay as NumericPreference<Double>?
| public static final Preference<Boolean> statusScrollNormalisingTransform = | ||
| BooleanType.create("statusScrollNormalisingTransform", false); | ||
| public static final Preference<Boolean> statusScrollDoubleBuffered = | ||
| BooleanType.create("statusScrollDoubleBuffered", true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these temporary preferences meant to still be here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Until you get something that works
|
I got sidetracked by the whole IDE failing to work after the GDX commit. This will be converted to draft when I get back to my computer. Currently trying to find render settings that will satisfy @kwvanderlinde desire for no artifacts and actually being visible on screen changes. |
1 similar comment
|
I got sidetracked by the whole IDE failing to work after the GDX commit. This will be converted to draft when I get back to my computer. Currently trying to find render settings that will satisfy @kwvanderlinde desire for no artifacts and actually being visible on screen changes. |
Identify the Bug or Feature request
You can link a pull request to an issue with one of
addresses #5353
#5353 (comment)
Description of the Change
Fixed duplicate key name in preferences
Possible Drawbacks
none
Documentation Notes
n/a
Release Notes
n/a
This change is