Skip to content

Conversation

@Baaaaaz
Copy link
Contributor

@Baaaaaz Baaaaaz commented Aug 30, 2025

Identify the Bug or Feature request

fixes #5766

Description of the Change

  1. updateDrawable() now updates the drawable as well as the pen.
  2. change to id compare approach in findDrawables() from using == to equals as the above change meant sometimes templates selected using a mouse click were not 'found' using the == approach.

Possible Drawbacks

None foreseen

Documentation Notes

None

Release Notes

Fix for 1.19 Drawing/Template Pointer Tool


This change is Reviewable

@github-actions github-actions bot added the bug label Aug 30, 2025
@Baaaaaz
Copy link
Contributor Author

Baaaaaz commented Sep 5, 2025

'Tis ready for a review and adding to 1.19. Thanks.

@kwvanderlinde kwvanderlinde moved this from Todo to Awaiting-Review in MapTool 1.19 Sep 5, 2025
@github-project-automation github-project-automation bot moved this from Awaiting-Review to To-Be-Merged in MapTool 1.19 Sep 5, 2025
@kwvanderlinde kwvanderlinde added this pull request to the merge queue Sep 5, 2025
Merged via the queue into RPTools:develop with commit e9e2365 Sep 5, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from To-Be-Merged to Merged in MapTool 1.19 Sep 5, 2025
@Baaaaaz Baaaaaz deleted the bugfix/5766-drawing-pointer-tool-fixes branch September 5, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Merged

Development

Successfully merging this pull request may close these issues.

[Bug]: Template Pointer Tool (due in 1.19) not updating connected clients

2 participants