Skip to content

Conversation

@cwisniew
Copy link
Member

@cwisniew cwisniew commented Sep 17, 2025

Identify the Bug or Feature request

#5643

Description of the Change

Added a No StatSheet option and cleaned up the stat-sheet location combo box on the campaign properties and edit toke dialogs so that it is disabled when the location can't be set.

Possible Drawbacks

Should be none

Documentation Notes

Its now possible to set the stat sheet type as "No Stat Sheet"

Release Notes

Its now possible to set the stat sheet type as "No Stat Sheet"


This change is Reviewable

@kwvanderlinde
Copy link
Collaborator

The Stat Sheet Location field in the New Token dialog should also be disabled when set to "No Stat Sheet":
image

I also think it would make sense if the "No Stat Sheet" option would be presented first in the various combo boxes rather than being sorted alphabetically with the rest.

@cwisniew
Copy link
Member Author

The Stat Sheet Location field in the New Token dialog should also be disabled when set to "No Stat Sheet": image

I also think it would make sense if the "No Stat Sheet" option would be presented first in the various combo boxes rather than being sorted alphabetically with the rest.

Doh, had the preference to display that dialog off so I missed it, brain is getting really rusty, thanks for picking it up.

I have updated that dialog and changed all 3 places (new token dialog, campaign properties, and edit token dialog) so that the stat sheets are ordered in such a way that all internal stat sheets (default, legacy, no) appear in the list before non internal stat sheets.

@kwvanderlinde kwvanderlinde moved this from Todo to To-Be-Merged in MapTool 1.19 Sep 18, 2025
@kwvanderlinde kwvanderlinde linked an issue Sep 18, 2025 that may be closed by this pull request
@kwvanderlinde kwvanderlinde added the feature Adding functionality that adds value label Sep 18, 2025
@cwisniew cwisniew added this pull request to the merge queue Sep 18, 2025
Merged via the queue into RPTools:develop with commit bd70c32 Sep 18, 2025
4 checks passed
@github-project-automation github-project-automation bot moved this from To-Be-Merged to Merged in MapTool 1.19 Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Adding functionality that adds value

Projects

Status: Merged

Development

Successfully merging this pull request may close these issues.

[Feature]: Set a token to have no stat-sheet

2 participants