Add table lines to Edit Token dialog's speech table #5890
Merged
+70
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is now called `MapTool#configureLaf()` since it doesn't really set up anything JIDE-specific aside from LAF properties. The code has also been unwrapped from the surrounding `LookAndFeelFactory.UIDefaultsCustomizer` since that is just a callback that gets immediately invoked, and this isn't JavaScript.
It is now update to individual tables to decide whether they need borders. Most table leave the borders disabled. The only tables to enable them are the ones that need to support editing by the user, including the addition of new rows: - The Speech table in the **Edit Token** dialog. - The table in the **Edit Table** dialog. While there are other editable tables, they are more specialized and so do not have the same usability issues.
This makes is much clearer which cell is being edited as the UI for indicating that is not obscured by the row highlight. Since uneditable tables don't need such feedback, and since row selection is sometimes a key feature for such tables, the highlighting has been left in place for those tables. The only affected tables are thus the **Edit Token** dialog's speech table, and the **Edit Table* dialog's table.
kwvanderlinde
force-pushed
the
bugfix/5814-table-cell-borders
branch
from
e72a7a9 to
3d28efe
Compare
cwisniew
approved these changes
Nov 28, 2025
github-project-automation
bot
moved this from Awaiting-Review
to To-Be-Merged
in MapTool 1.19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Fixes #5814
Description of the Change
This enables both horizontal and vertical lines for
JTableat the look-and-feel level. Individual tables can then decide whether to display the lines using theirshowHorizontalLinesandshowVerticalLinesproperties. Most tables leave these properties disabled, but these editable tables enable the lines:The inclusion of lines makes these tables easier to use as the user is now aware that extra blank rows exist at the end of the table for them to extend the table. To further improve the UX for these tables, the row selection highlight has also been disabled so that the current cell's highlight is visible without having to strain the eyes.
There are some other editable tables, but they are more specialized and do not use a default JTable. E.g., the token properties in Edit Token. Such tables do not have the same usability issues, or already do not follow the table L&F on this point, so they have not been changed.
Possible Drawbacks
Should not be any.
Documentation Notes
Editing the Speech table in the Edit Token should be clearer in 1.19 compared to 1.18 and earlier. Old (top right cell selected for editing):
The same situation now looks like:
And similarly in the Edit Table dialog:
is now:
Release Notes
This change is