Fix null stat sheet location #5894
Merged
+15
−78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The location is not permitted to be `null`, so instead pass the default of `BOTTOM_LEFT` as in other places.
There were several callers that had to check for a `null` location and replace it with the default of `BOTTOM_LEFT`. That is no longer necessary since the `StatSheetProperties` constructor will do so.
THere were several places where `StatSheetManager` instances had to be conjured out of nowhere just to append the namespace and name into an ID. This is no longer necessary as `StatSheet#id()` will do the same without involving a `StatSheetManager`.
cwisniew
approved these changes
Nov 30, 2025
github-project-automation
bot
moved this from Awaiting-Review
to To-Be-Merged
in MapTool 1.19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Fixes NPE related to #5643
Description of the Change
Changes the
StatSheetPropertiesconstructor to handle anulllocation and replace it with the default ofStatSheetLocation#BOTTOM_LEFT. The various callers that did this same replacement have been updated to just passnull.I also noticed that anywhere we need a
StatSheet's ID, we would conjure up a newStatSheetManagerto build the ID. That seemed odd, so I also moved that responsibility to theStatSheetrecord itself, streamlining callers and eliminating a few redundant methods fromStatSheetManager.Possible Drawbacks
None
Documentation Notes
N/A
Release Notes
N/A
This change is