Skip to content

Conversation

@kwvanderlinde
Copy link
Collaborator

@kwvanderlinde kwvanderlinde commented Dec 13, 2025

Identify the Bug or Feature request

Resolves #5324

Description of the Change

Adds support to WallTopologyTool for selecting multiple walls at one time. There are two ways to modify the selection:

  1. Left clicking. Without holding shift, this is the same behaviour as before (selecting one wall). Holding shift will toggle whether the clicked wall is selected.
  2. Left-dragging. This draws a selection box similar to other tools. When the mouse is released, walls within the selection box will become the new selection. If shift is held, the walls will instead be added to the existing selection instead of replacing the selection.

When multiple walls are selected, the configuration panel will blank out any options that don't have a common value for all walls. When changing any option, including a blanked out option, the new value will be applied to all selected walls.

Possible Drawbacks

Should be none

Documentation Notes

The wall topology tool supports these new actions:

  • Shift+left click will add or remove the clicked wall from the current selection.
  • Dragging with the left mouse button will draw a selection box. Releasing the left mouse button will set the walls inside the selection box as the selected walls. If the shift key is held, the newly selected walls will be added to the existing selection instead of replacing the selection.

Release Notes

  • Add ability to select multiple walls using shift+left clicking or left-dragging.

This change is Reviewable

The configuration panel and internals of `WallTopologTool` can handle a list of selected walls.

There is no tool support for selecting multiple walls yet, so the selection list will either be empty of a singleton.
There are two ways to select multiple walls:
- By shift-clicking a wall to add or remove it from the selection.
- By left-dragging the mouse to draw a selection box. If shift is held, the covered walls will be added to the
  selection; otherwise, they will become the new selection.
@kwvanderlinde kwvanderlinde self-assigned this Dec 13, 2025
@github-actions github-actions bot added the feature Adding functionality that adds value label Dec 13, 2025
@kwvanderlinde kwvanderlinde moved this from Todo to Awaiting-Review in MapTool 1.19 Dec 13, 2025
@github-project-automation github-project-automation bot moved this from Awaiting-Review to To-Be-Merged in MapTool 1.19 Dec 14, 2025
@cwisniew cwisniew added this pull request to the merge queue Dec 14, 2025
Merged via the queue into RPTools:develop with commit 59ce642 Dec 14, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from To-Be-Merged to Merged in MapTool 1.19 Dec 14, 2025
@kwvanderlinde kwvanderlinde deleted the feature/5324-wall-mass-selection branch December 15, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Adding functionality that adds value

Projects

Status: Merged

Development

Successfully merging this pull request may close these issues.

[Feature]: Add multiple selection of walls

2 participants