Fix Drawing ID not unique on shape.draw() #5926
Merged
+10
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"batik-transcoder". Changed "batik" to a bundle containing all three.
"batik-transcoder" which contain the classes: batik.ext.awt.geom.ExtendedGeneralPath, batik.ext.awt.geom.Polygon2D, batik.parser.AWTPathProducer, batik.parser.ParseException, and batik.parser.PathParser. Changed "batik" to a bundle containing all three.
constructor was copying the id. Changed to generate a new ID on the copy.
drawnElement to "shapeDrawable.copy()" to enforce a new ID.
cwisniew
approved these changes
Jan 19, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
fixes #5920
closes #5920
Description of the Change
Changed
AbstractDrawing(AbstractDrawing other)to generate a new ID.Changed
shape.draw()to use... drawnElement = new DrawnElement(shapeDrawable.copy()...to enforce a unique ID.Test results for the same shape drawn ten times;
lib:shapeTest:
Possible Drawbacks
none
Documentation Notes
BugFix: shape.draw() returning duplicate IDs on multiple calls for the same shape.
Release Notes
BugFix: shape.draw() returning duplicate IDs on multiple calls for the same shape.
This change is