add volg to init.nc and add a new stream property gattr_update to turn on/off the update of global attributes#12
Merged
guoqing-noaa merged 6 commits intogsl/developfrom Oct 22, 2025
Merged
Conversation
…UPDATE_YES) then'
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new stream property gattr_update that allows users to control whether global attributes are updated during stream output operations. The property defaults to "yes" (enabled) to maintain backward compatibility.
Key changes:
- Added
gattr_updateas a configurable stream property with "yes"/"no" values - Modified the stream output logic to conditionally update global attributes based on this setting
- Updated the C/Fortran interface to pass the new property between language boundaries
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| xml_stream_parser.c | Parses gattr_update XML attribute and passes integer flag to stream manager |
| mpas_stream_manager_types.inc | Defines constants for the new MPAS_STREAM_PROPERTY_GATTR_UPDATE property |
| mpas_stream_manager.F | Implements gattr_update property throughout stream lifecycle and conditionally writes attributes |
| mpas_stream_list_types.inc | Adds gattr_update field to stream structure with default value of 1 |
| Registry.xml | Adds new volg variable for graupel particle volume (unrelated to main PR purpose) |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
gattr_update to turn on/off the update of global attributesvolg to init.nc and add a new stream property gattr_update to turn on/off the update of global attributes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.