Skip to content

add volg to init.nc and add a new stream property gattr_update to turn on/off the update of global attributes#12

Merged
guoqing-noaa merged 6 commits intogsl/developfrom
coldstartDA2
Oct 22, 2025
Merged

add volg to init.nc and add a new stream property gattr_update to turn on/off the update of global attributes#12
guoqing-noaa merged 6 commits intogsl/developfrom
coldstartDA2

Conversation

@guoqing-noaa
Copy link
Copy Markdown

No description provided.

@guoqing-noaa guoqing-noaa requested a review from Copilot October 22, 2025 16:23
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new stream property gattr_update that allows users to control whether global attributes are updated during stream output operations. The property defaults to "yes" (enabled) to maintain backward compatibility.

Key changes:

  • Added gattr_update as a configurable stream property with "yes"/"no" values
  • Modified the stream output logic to conditionally update global attributes based on this setting
  • Updated the C/Fortran interface to pass the new property between language boundaries

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
xml_stream_parser.c Parses gattr_update XML attribute and passes integer flag to stream manager
mpas_stream_manager_types.inc Defines constants for the new MPAS_STREAM_PROPERTY_GATTR_UPDATE property
mpas_stream_manager.F Implements gattr_update property throughout stream lifecycle and conditionally writes attributes
mpas_stream_list_types.inc Adds gattr_update field to stream structure with default value of 1
Registry.xml Adds new volg variable for graupel particle volume (unrelated to main PR purpose)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread src/core_init_atmosphere/Registry.xml
Comment thread src/framework/xml_stream_parser.c
@guoqing-noaa guoqing-noaa changed the title add a new stream property gattr_update to turn on/off the update of global attributes add volg to init.nc and add a new stream property gattr_update to turn on/off the update of global attributes Oct 22, 2025
@guoqing-noaa guoqing-noaa merged commit 8470b68 into gsl/develop Oct 22, 2025
@guoqing-noaa guoqing-noaa deleted the coldstartDA2 branch October 22, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants