Skip to content

Conversation

@Robadob
Copy link
Member

@Robadob Robadob commented Feb 27, 2024

Working through notes from #18, hoping to fix small stuff before next Thursday's first run with students.
I'll clean up comments in that issue at a later point.

Closes #19

Appears issue was using single quotes, that then appeared in string. Fixed two known issues and updated others that I spotted.
@github-actions
Copy link

github-actions bot commented Feb 27, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/RSE-Sheffield/pando-python/compare/md-outputs..md-outputs-PR-20

The following changes were observed in the rendered markdown documents:

 fig/latency.png                                   |  Bin 13555 -> 13957 bytes
 fig/latency.py                                    |    4 +-
 fig/stack.ai (new)                                | 5745 +++++++++++++++++++++
 fig/stack.png (new)                               |  Bin 0 -> 27427 bytes
 files/pred-prey/predprey_out.png (new)            |  Bin 0 -> 68125 bytes
 files/schelling_out.prof (new)                    |  Bin 0 -> 1704740 bytes
 files/travelling-sales/profiles.zip (new)         |  Bin 0 -> 46150 bytes
 files/travelling-sales/profiles/out_01.prof (new) |  Bin 0 -> 14431 bytes
 files/travelling-sales/profiles/out_02.prof (new) |  Bin 0 -> 14431 bytes
 files/travelling-sales/profiles/out_03.prof (new) |  Bin 0 -> 14431 bytes
 files/travelling-sales/profiles/out_04.prof (new) |  Bin 0 -> 14431 bytes
 files/travelling-sales/profiles/out_05.prof (new) |  Bin 0 -> 14431 bytes
 files/travelling-sales/profiles/out_06.prof (new) |  Bin 0 -> 14431 bytes
 files/travelling-sales/profiles/out_07.prof (new) |  Bin 0 -> 14431 bytes
 files/travelling-sales/profiles/out_08.prof (new) |  Bin 0 -> 14431 bytes
 files/travelling-sales/profiles/out_09.prof (new) |  Bin 0 -> 14431 bytes
 files/travelling-sales/profiles/out_10.prof (new) |  Bin 0 -> 14431 bytes
 md5sum.txt                                        |   22 +-
 optimisation-conclusion.md                        |    2 +-
 optimisation-data-structures-algorithms.md        |  136 +-
 optimisation-introduction.md                      |   15 +-
 optimisation-memory.md                            |    4 +-
 optimisation-minimise-python.md                   |   74 +-
 optimisation-use-latest.md                        |    2 +-
 profiling-conclusion.md                           |    4 +-
 profiling-functions.md                            |   97 +-
 profiling-introduction.md                         |    2 +-
 profiling-lines.md                                |    4 +-
 setup.md                                          |    4 +-
 29 files changed, 5956 insertions(+), 159 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-03-06 09:18:39 +0000

github-actions bot pushed a commit that referenced this pull request Feb 27, 2024
github-actions bot pushed a commit that referenced this pull request Feb 27, 2024
github-actions bot pushed a commit that referenced this pull request Feb 27, 2024
github-actions bot pushed a commit that referenced this pull request Feb 27, 2024
github-actions bot pushed a commit that referenced this pull request Mar 5, 2024
github-actions bot pushed a commit that referenced this pull request Mar 5, 2024
github-actions bot pushed a commit that referenced this pull request Mar 5, 2024
github-actions bot pushed a commit that referenced this pull request Mar 5, 2024
github-actions bot pushed a commit that referenced this pull request Mar 5, 2024
github-actions bot pushed a commit that referenced this pull request Mar 5, 2024
github-actions bot pushed a commit that referenced this pull request Mar 5, 2024
github-actions bot pushed a commit that referenced this pull request Mar 5, 2024
github-actions bot pushed a commit that referenced this pull request Mar 5, 2024
github-actions bot pushed a commit that referenced this pull request Mar 5, 2024
github-actions bot pushed a commit that referenced this pull request Mar 5, 2024
github-actions bot pushed a commit that referenced this pull request Mar 5, 2024
github-actions bot pushed a commit that referenced this pull request Mar 5, 2024
@Robadob Robadob force-pushed the accelerated_feedback_1 branch from 4e4d8e2 to 19bf3e4 Compare March 6, 2024 08:58
github-actions bot pushed a commit that referenced this pull request Mar 6, 2024
@Robadob Robadob marked this pull request as ready for review March 6, 2024 19:00
@Robadob
Copy link
Member Author

Robadob commented Mar 6, 2024

Merging this ahead of tomorrow's session.

@Robadob Robadob merged commit f232601 into main Mar 6, 2024
@Robadob Robadob deleted the accelerated_feedback_1 branch March 6, 2024 19:01
Robadob pushed a commit that referenced this pull request Jun 11, 2024
This will add `learners/reference.md`, which will fix #20
Robadob pushed a commit that referenced this pull request Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Formatting of Key Points on final episode

2 participants